Add information about crate builds#3328
Conversation
d4252e6 to
336c521
Compare
336c521 to
8f2ddcc
Compare
|
@syphar It's ready for review. Not sure why |
with sqlx some thing are odd, |
6be9069 to
62d5235
Compare
|
Apart from CI (weird) errors, ready for review. |
This comment has been minimized.
This comment has been minimized.
62d5235 to
5a2ed8e
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I updated sqlx & pushed to your branch, the one build test is failing, perhaps just ordering?
I had other comments, but they aren't blocking the merge, and feel more philosophical than real issues.
One addition (I can also make later) is then updating the fake-release etc to match the "new" way.
|
@GuillaumeGomez want to have a look at the last commit? adding the build-logs to the test-fakes surfaced some bugs, which I solved then. |
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Looks good to me, thanks for the help! :) |
Fixes #3318.
The build logs now look like this:
The page listing builds now take into account if all builds succeeded or not (and adds a warning sign in such a case).
I also tweaked the
gui-test/tester.jsto make it possible to run only some tests, quite convenient. :3