Skip to content

Add information about crate builds#3328

Merged
GuillaumeGomez merged 10 commits into
rust-lang:mainfrom
GuillaumeGomez:crate-builds-info
May 19, 2026
Merged

Add information about crate builds#3328
GuillaumeGomez merged 10 commits into
rust-lang:mainfrom
GuillaumeGomez:crate-builds-info

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented May 8, 2026

Fixes #3318.

The build logs now look like this:

Screenshot From 2026-05-09 02-07-46

The page listing builds now take into account if all builds succeeded or not (and adds a warning sign in such a case).

I also tweaked the gui-test/tester.js to make it possible to run only some tests, quite convenient. :3

@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 8, 2026
@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review May 9, 2026 01:23
@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner May 9, 2026 01:23
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

@syphar It's ready for review. Not sure why sqlx testsuite is not happy. When running cargo sqlx prepare --workspace locally, nothing changes. Dark magic.

@syphar
Copy link
Copy Markdown
Member

syphar commented May 12, 2026

@syphar It's ready for review. Not sure why sqlx testsuite is not happy. When running cargo sqlx prepare --workspace locally, nothing changes. Dark magic.

with sqlx some thing are odd, just sqlx-prepare should work.

Copy link
Copy Markdown
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

I have one design change in mind, happy to discuss.

View changes since this review

Comment thread crates/lib/docs_rs_types/src/build_status.rs Outdated
Comment thread crates/lib/docs_rs_database/src/releases.rs Outdated
Comment thread crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs
@GuillaumeGomez GuillaumeGomez force-pushed the crate-builds-info branch 2 times, most recently from 6be9069 to 62d5235 Compare May 13, 2026 01:33
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Apart from CI (weird) errors, ready for review.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

Copy link
Copy Markdown
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated sqlx & pushed to your branch, the one build test is failing, perhaps just ordering?

I had other comments, but they aren't blocking the merge, and feel more philosophical than real issues.

One addition (I can also make later) is then updating the fake-release etc to match the "new" way.

View changes since this review

Comment thread crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs Outdated
Comment thread crates/bin/docs_rs_web/src/handlers/build_details.rs
Comment thread crates/bin/docs_rs_web/src/handlers/builds.rs
@syphar
Copy link
Copy Markdown
Member

syphar commented May 18, 2026

@GuillaumeGomez want to have a look at the last commit?

adding the build-logs to the test-fakes surfaced some bugs, which I solved then.

@rustbot

This comment has been minimized.

@syphar syphar force-pushed the crate-builds-info branch from 52d3a7d to 105605b Compare May 18, 2026 03:18
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 18, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar syphar force-pushed the crate-builds-info branch from 105605b to 04803b1 Compare May 18, 2026 06:08
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Looks good to me, thanks for the help! :)

@GuillaumeGomez GuillaumeGomez enabled auto-merge (rebase) May 18, 2026 22:56
@GuillaumeGomez GuillaumeGomez requested a review from syphar May 18, 2026 22:56
Copy link
Copy Markdown
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeGomez GuillaumeGomez merged commit 606ab8c into rust-lang:main May 19, 2026
11 checks passed
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 19, 2026
@GuillaumeGomez GuillaumeGomez deleted the crate-builds-info branch May 19, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builds status page should be more clear

3 participants