Skip to content

gui-tests: explicitly install chrome in docker image, fix lint-js#3347

Merged
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:use-ubuntu-24
May 22, 2026
Merged

gui-tests: explicitly install chrome in docker image, fix lint-js#3347
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:use-ubuntu-24

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented May 22, 2026

  • gui tests randomly started failing, probably because of an update of a non-locked version of something. I couldn't quickly figure out the exact problem (because , JS), so I just apt install chromium, which works.
  • lint-js also started randomly failing. This is likely because there is a new deno version (2.8). We freeze the deno version now in CI.

I'm aware that there is probably ( likely ) a nicer / more future proof way of fixing these issues, but I want to unblock open PRs (#3274, #3348 ), so I can publish / merge / deploy.

@syphar syphar requested a review from a team as a code owner May 22, 2026 10:33
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 22, 2026
@syphar syphar self-assigned this May 22, 2026
@syphar syphar changed the title use ubuntu-24 image for gui-tests gui-tests: explicitly install headless chrome May 22, 2026
@syphar syphar changed the title gui-tests: explicitly install headless chrome gui-tests: explicitly install headless chrome May 22, 2026
@syphar syphar changed the title gui-tests: explicitly install headless chrome gui-tests: explicitly install chrome in docker image May 22, 2026
@syphar syphar changed the title gui-tests: explicitly install chrome in docker image gui-tests: explicitly install chrome in docker image, fix lint-js May 22, 2026
@syphar syphar requested a review from GuillaumeGomez May 22, 2026 15:30
@GuillaumeGomez GuillaumeGomez merged commit 06a8035 into rust-lang:main May 22, 2026
13 checks passed
@GuillaumeGomez GuillaumeGomez deleted the use-ubuntu-24 branch May 22, 2026 15:31
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 22, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants