Skip to content

xous: add initial C definitions#3084

Merged
bors merged 1 commit into
rust-lang:masterfrom
betrusted-io:initial-xous-support
Feb 5, 2023
Merged

xous: add initial C definitions#3084
bors merged 1 commit into
rust-lang:masterfrom
betrusted-io:initial-xous-support

Conversation

@xobs

@xobs xobs commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

This adds initial C definitions to Xous. There is no C library, so this mostly serves to add C-compatible exports to the libc crate.

This adds initial C definitions to Xous. There is no C library, so this
mostly serves to add C-compatible exports to the `libc` crate.

Signed-off-by: Sean Cross <sean@xobs.io>
@rustbot

rustbot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@xobs

xobs commented Jan 22, 2023

Copy link
Copy Markdown
Contributor Author

Note that I have NOT added a file to libc/semver/ because Xous has no C functions, and so this file would be empty.

@JohnTitor

Copy link
Copy Markdown
Member

We're pausing accepting external targets currently, see #3032 for details.

@xobs

xobs commented Jan 28, 2023

Copy link
Copy Markdown
Contributor Author

What is classified as an external target? Is it only tier 2 and lower?

Comment thread Cargo.toml Outdated
@JohnTitor

Copy link
Copy Markdown
Member

Ah I thought there was no official target for xous but it's not true (that's what we discussed in the above linked PR, read it for the context). r=me once the above is resolved.

@xobs xobs force-pushed the initial-xous-support branch from 67d8295 to be1d79d Compare February 5, 2023 02:09
@xobs

xobs commented Feb 5, 2023

Copy link
Copy Markdown
Contributor Author

Alright, I removed that commit. Note that the freebsd build is broken due to what apparently is a missing symbol in curl, preventing it from downloading things.

r=johntitor

@JohnTitor

Copy link
Copy Markdown
Member

Thanks!

Note that the freebsd build is broken due to what apparently is a missing symbol in curl, preventing it from downloading things.

It has been fixed on master, it happens because the branch here is a bit old, so no problem at all :)

@JohnTitor

Copy link
Copy Markdown
Member

Oh I forgot: @bors r+

@bors

bors commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

📌 Commit be1d79d has been approved by JohnTitor

It is now in the queue for this repository.

@bors

bors commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit be1d79d with merge 7349741...

@bors

bors commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 7349741 to master...

@bors bors merged commit 7349741 into rust-lang:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants