Skip to content

Support capturing of std::net types#724

Merged
KodrAus merged 5 commits into
masterfrom
feat/net-to-value
May 20, 2026
Merged

Support capturing of std::net types#724
KodrAus merged 5 commits into
masterfrom
feat/net-to-value

Conversation

@KodrAus
Copy link
Copy Markdown
Contributor

@KodrAus KodrAus commented May 17, 2026

Rebase of #721

Closes #711

I've taken the original implementation from #721 and tweaked it to maintain consistent behaviour between our internal capturing, and value-bag's. Thanks for originally working on this @JonathanWilbur!

@KodrAus
Copy link
Copy Markdown
Contributor Author

KodrAus commented May 17, 2026

I'll need to feature gate these on std, since they're not available in core until 1.77.

@KodrAus KodrAus marked this pull request as draft May 17, 2026 00:24
@KodrAus KodrAus marked this pull request as ready for review May 19, 2026 10:03
@KodrAus
Copy link
Copy Markdown
Contributor Author

KodrAus commented May 19, 2026

r? @Thomasdezeeuw

@rustbot
Copy link
Copy Markdown

rustbot commented May 19, 2026

Failed to set assignee to Thomasdezeeuw: req=https://api.github.com/repos/rust-lang/log/issues/724/assignees (x-github-request-id: B205:555DB:3271BCD:3315909:6A0C3569): {"message":"Must have admin rights to Repository.","documentation_url":"https://docs.github.com/rest/issues/assignees#add-assignees-to-an-issue","status":"403"}

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Copy link
Copy Markdown
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

A lot of this types have been stabilised as core::net:: as well in 1.77 (released 21 March, 2024). Should we start keeping a lit of these kind of improvements we can do once we bump the MSRV?

@KodrAus
Copy link
Copy Markdown
Contributor Author

KodrAus commented May 20, 2026

That might be a good idea 👍 The other big one is Error, which is available from 1.81.0

@KodrAus KodrAus merged commit 7ccd873 into master May 20, 2026
26 checks passed
@KodrAus KodrAus deleted the feat/net-to-value branch May 20, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ToValue for IpAddr, and SocketAddr

4 participants