Use mem::take instead of mem::replace when applicable#4881
Merged
bors merged 8 commits intoJan 4, 2020
Conversation
krishna-veerareddy
changed the title
mem::take instead of mem::replace when applicablemem::take instead of mem::replace when applicable
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
from
401b3d1 to
64855de
Compare
krishna-veerareddy
changed the title
mem::take instead of mem::replace when applicablemem::take instead of mem::replace when applicable
flip1995
added
S-waiting-on-review
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
2 times, most recently
from
0f6b46c to
38bb08d
Compare
tesuji
reviewed
Dec 8, 2019
tesuji
reviewed
Dec 8, 2019
Contributor
Author
|
@lzutao Hey I added checks so that it doesn't lint within macros. Also added some macro test cases to prevent regressions in the future. |
tesuji
reviewed
Dec 9, 2019
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
from
8a27af3 to
5c225e1
Compare
Contributor
|
☔ The latest upstream changes (presumably #4932) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
approved these changes
Dec 22, 2019
Member
There was a problem hiding this comment.
LGTM! Linting in internal macros would be good though. On how to test this see my comment #4881 (comment)
Member
|
And sorry for the late reply, I was on vacation. |
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
from
5c225e1 to
38e7bd2
Compare
tesuji
reviewed
Dec 22, 2019
Contributor
|
If you change - if func_args.len() == 2;
+ if let [dest, src] = &**func_args; |
This comment has been minimized.
This comment has been minimized.
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
2 times, most recently
from
8d1f0fc to
5d8366f
Compare
tesuji
reviewed
Dec 24, 2019
Member
|
@bors r+ Thanks! |
Contributor
|
📌 Commit aca6815 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Dec 28, 2019
…lip1995 Use `mem::take` instead of `mem::replace` when applicable `std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`. Fixes issue #4871 changelog: Added lint for [`mem_replace_with_default`]
Contributor
|
💔 Test failed - checks-travis |
Member
|
|
Contributor
|
💔 Test failed - status-appveyor |
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
from
45e7b87 to
f1e22c8
Compare
Contributor
Author
`std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`.
Also added test cases for internal and external macros.
krishna-veerareddy
force-pushed
the
issue-4871-use-mem-take
branch
from
f1e22c8 to
42e4595
Compare
Contributor
Author
Contributor
|
@bors r=flip1995 |
Contributor
|
📌 Commit 42e4595 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jan 4, 2020
…lip1995 Use `mem::take` instead of `mem::replace` when applicable `std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`. Fixes issue #4871 changelog: Added lint for [`mem_replace_with_default`]
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 8, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 8, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 8, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 8, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 9, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 9, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
added a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 9, 2026
This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the regular test files -- both the std and the no-std one. [^1]: rust-lang#4881 (comment)
ada4a
pushed a commit
to ada4a/rust-clippy
that referenced
this pull request
Jun 9, 2026
…17191) This was originally not done because emitting suggestions in macros used to not work well.[^1] That's fortunately no longer the case. This allows folding `mem_replace_with_default_macro` into the other test files -- both the regular and the no-std one. changelog: [`mem_replace_with_default`]: also emit inside macros [^1]: rust-lang#4881 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::mem::takecan be used to replace a value of typeTwithT::default()instead ofstd::mem::replace.Fixes issue #4871
changelog: Added lint for [
mem_replace_with_default]