Fix redundant_clone lint not working with PathBuf and OsString#5017
Merged
Conversation
sinkuu
force-pushed
the
mir_no_opt_fallout
branch
from
a9d44be to
99eec3f
Compare
Member
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 99eec3f has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jan 8, 2020
Fix redundant_clone lint not working with PathBuf and OsString #4825 diabled MIR optimization in clippy, including `rustc_mir::transform::InstCombine` which reduces `&(*x)` to `x`. This PR tries to unwrap `&*` when looking into `mir::Rvalue`s. Fixes #5014. --- changelog: fixed `redundant_clone` lint not working with `PathBuf` and `OsString`
Contributor
|
💔 Test failed - checks-travis |
Contributor
Author
|
It looks like a sprious networking error. |
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Jan 8, 2020
Fix redundant_clone lint not working with PathBuf and OsString #4825 diabled MIR optimization in clippy, including `rustc_mir::transform::InstCombine` which reduces `&(*x)` to `x`. This PR tries to unwrap `&*` when looking into `mir::Rvalue`s. Fixes #5014. --- changelog: fixed `redundant_clone` lint not working with `PathBuf` and `OsString`
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4825 diabled MIR optimization in clippy, including
rustc_mir::transform::InstCombinewhich reduces&(*x)tox. This PR tries to unwrap&*when looking intomir::Rvalues.Fixes #5014.
changelog: fixed
redundant_clonelint not working withPathBufandOsString