Skip to content

Stabilize binary_heap_as_slice#124012

Merged
bors merged 1 commit into
rust-lang:masterfrom
slanterns:as_slice_stabilize
Jun 7, 2024
Merged

Stabilize binary_heap_as_slice#124012
bors merged 1 commit into
rust-lang:masterfrom
slanterns:as_slice_stabilize

Conversation

@slanterns

@slanterns slanterns commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

This PR stabilizes binary_heap_as_slice:

// std::collections::BinaryHeap

impl BinaryHeap<T> {
    pub fn as_slice(&self) -> &[T]
}

Tracking issue: #83659.
Implementation PR: #82331.

FCPs already completed in the tracking issue.

Closes #83659.

r? libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2024
@slanterns

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@slanterns

slanterns commented Apr 16, 2024

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2024
@slanterns

slanterns commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

ping @BurntSushi

@BurntSushi

BurntSushi commented Jun 7, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d5d56d0 has been approved by BurntSushi

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 7, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 7, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 7, 2024
Merged
@bors bors merged commit 0acb5b8 into rust-lang:master Jun 7, 2024
@rustbot rustbot added this to the 1.80.0 milestone Jun 7, 2024
@slanterns slanterns deleted the as_slice_stabilize branch June 8, 2024 05:30
@BoxyUwU BoxyUwU added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushi BurntSushi

Labels

relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for alloc::collections::BinaryHeap::as_slice

6 participants

@slanterns @rust-log-analyzer @BurntSushi @bors @BoxyUwU @rustbot