Skip to content

Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021

Open
WaffleLapkin wants to merge 5 commits into
rust-lang:mainfrom
WaffleLapkin:box-arr-into-iter2
Open

Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021
WaffleLapkin wants to merge 5 commits into
rust-lang:mainfrom
WaffleLapkin:box-arr-into-iter2

Conversation

@WaffleLapkin

@WaffleLapkin WaffleLapkin commented Dec 8, 2024 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35 tgross35 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 13, 2024
@WaffleLapkin WaffleLapkin marked this pull request as ready for review December 16, 2024 19:24
@tgross35 tgross35 added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Dec 19, 2024
@bors

bors commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

scottmcm
scottmcm reviewed Feb 24, 2025
View reviewed changes
Comment thread library/alloc/src/boxed/iter.rs
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025
@WaffleLapkin

WaffleLapkin commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

@scottmcm anything I can do to move this forward?

@rust-bors

This comment was marked as resolved.

Sign in to view
@scottmcm

This comment was marked as resolved.

Sign in to view
@rustbot rustbot assigned Mark-Simulacrum and unassigned scottmcm Feb 8, 2026
Mark-Simulacrum
Mark-Simulacrum requested changes Feb 14, 2026
View reviewed changes

@Mark-Simulacrum Mark-Simulacrum left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this also needs rebasing + FCP, maybe starting with the FCP makes sense since it's not obvious to me this is worth it (especially if it needs an edition change...)

View changes since this review

Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread tests/ui/iterators/into-iter-on-arrays-lint.stderr
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the box-arr-into-iter2 branch 2 times, most recently from 33ce55c to a26c96f Compare March 10, 2026 15:10
@WaffleLapkin
Bless tests
6bf1d93 
Note: this removes warnings, as this breakage was deemed acceptable, see
<rust-lang#124108 (comment)>
@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@WaffleLapkin

WaffleLapkin commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@BurntSushi doing a crater run seems reasonable to me. I'll start it once the try build completes.

@bors try

rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
@bors
Auto merge of #134021 - WaffleLapkin:box-arr-into-iter2, r=<try>
c37f0ee 
Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

rust-log-analyzer commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
...............................F.................. (50/144)
.................................................. (100/144)
............................................       (144/144)

======== tests/rustdoc-gui/go-to-collapsed-elem.goml ========

[ERROR] line 40
    at `tests/rustdoc-gui/go-to-collapsed-elem.goml` line 21: Error: Node is detached from document: for command `click: "//*[@id='search']//a[@href='../test_docs/struct.Foo.html#method.must_use']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.Foo.html?search=t_use>


<= doc-ui tests done: 143 succeeded, 1 failed, 0 filtered out

Error: ()

@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c37f0ee (c37f0eebe7e1f4c42e88bffc7961c6a7aa9c4d00, parent: 057ed8ba87418a77d5758f2d5e13f84b89b197e9)

@WaffleLapkin

WaffleLapkin commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@craterbot check

@craterbot

craterbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build c37f0ee
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Jun 9, 2026
@theemathas theemathas mentioned this pull request Jun 12, 2026
Closed
@theemathas

theemathas commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@craterbot cancel

See #157814

@craterbot

craterbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-134021 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 12, 2026
@theemathas

theemathas commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-157814-crater-rollup/retry-regressed-list.txt

@craterbot

craterbot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build c37f0ee
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2026
@craterbot

craterbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-134021 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@theemathas

theemathas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Crater appears to be stuck doing nothing. Requeueing the run.

@craterbot cancel

@craterbot

craterbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-134021 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 19, 2026
@theemathas

theemathas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@craterbot check p=2 crates=https://crater-reports.s3.amazonaws.com/pr-157814-crater-rollup/retry-regressed-list.txt

@craterbot

craterbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build c37f0ee
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@programmerjake programmerjake programmerjake left review comments

@scottmcm scottmcm scottmcm left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.