Skip to content

resolve: Consider traits from shadowed glob imports to be in scope#148943

Closed
petrochenkov wants to merge 1 commit into
rust-lang:mainfrom
petrochenkov:traitglobshadow
Closed

resolve: Consider traits from shadowed glob imports to be in scope#148943
petrochenkov wants to merge 1 commit into
rust-lang:mainfrom
petrochenkov:traitglobshadow

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Closes #144993.

TODO: this needs a crater run first of all.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2025
@rustbot

rustbot commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot added a commit that referenced this pull request Nov 14, 2025
resolve: Consider traits from shadowed glob imports to be in scope
@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2025
@petrochenkov

Copy link
Copy Markdown
Contributor Author

I'll better run crater on #148946, because it includes this changes as a subset.
@rustbot blocked

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 14, 2025
@petrochenkov petrochenkov removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 14, 2025
@rust-bors

rust-bors Bot commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 213ba58 (213ba58857e42241934d114390dfcd0779fc4662, parent: c880acdd3171dfafdb55be8cd9822a857e99348d)

@petrochenkov

Copy link
Copy Markdown
Contributor Author

@craterbot

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-148943 created and queued.
🤖 Automatically detected try build 213ba58
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 18, 2025
@craterbot

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-148943 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-148943 is completed!
📊 297 regressed and 0 fixed (2151 total)
📊 139 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-148943/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 19, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
@petrochenkov

Copy link
Copy Markdown
Contributor Author

Most of failures (297/321) in the crater run in #148946 (comment) are from this change.

@petrochenkov

Copy link
Copy Markdown
Contributor Author

I'm going to close this in favor of #149058, which is a more conservative and less breaking change.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 20, 2025
@petrochenkov petrochenkov deleted the traitglobshadow branch June 17, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shadowed traits from glob imports in the same scope get ignored

4 participants