Revert "resolve: Downgrade ambiguous_glob_imports to warn-by-default"#152549
Closed
petrochenkov wants to merge 1 commit into
Closed
Revert "resolve: Downgrade ambiguous_glob_imports to warn-by-default"#152549petrochenkov wants to merge 1 commit into
ambiguous_glob_imports to warn-by-default"#152549petrochenkov wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
petrochenkov
added
S-blocked
Member
|
r? compiler |
This reverts commit cd05071.
Contributor
Author
|
New beta branch was created, this can be merged. There's not much to review here, this revert implements the second step of lang team decision from #149845 (comment). |
rustbot
added
S-waiting-on-review
fmease
approved these changes
Mar 1, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 1, 2026
Revert "resolve: Downgrade `ambiguous_glob_imports` to warn-by-default" This reverts commit cd05071. Revert of rust-lang#151130. This will need to be merged after ~February 27 2026, when Rust 1.95 branches out from the main branch.
rust-bors Bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
…uwer Rollup of 6 pull requests Successful merges: - #153130 (std: move `getpid` to `sys::process`) - #152549 (Revert "resolve: Downgrade `ambiguous_glob_imports` to warn-by-default") - #153231 (diags: Pass `DiagArgMap` instead of `FluentArgs` into `format_diag_message`) - #153246 (Fix compile error in std::fs impl on VEXos target) - #153255 (Recover feature lang_items for emscripten) - #153257 (update my mailmap)
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
|
Member
|
Oof, bors approved & merged the pre-rebase commit 5c037af instead of the post-rebase one 28bfc26. I'm not sure why it did, my approval happened ~40mins after you pushed the rebase. I'm gonna ask on Zulip (edit: #t-infra/bors > Bors approved outdated commit while it shouldn't have?). This PR has effectively been merged via rollup #153260. |
Contributor
Author
|
It was indeed merged, closing. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cd05071.
Revert of #151130.
This will need to be merged after ~February 27 2026, when Rust 1.95 branches out from the main branch.