constify TryFrom<Vec> for array#155616
Merged
rust-bors[bot] merged 1 commit intoJun 16, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
Lars-Schumann
force-pushed
the
const-array-try-from-vec
branch
from
9c141c1 to
f59366f
Compare
This comment has been minimized.
This comment has been minimized.
Lars-Schumann
force-pushed
the
const-array-try-from-vec
branch
from
f59366f to
8acdb36
Compare
Lars-Schumann
commented
Apr 22, 2026
rustbot
added
S-waiting-on-review
Member
|
r? libs-api |
rustbot
added
the
T-libs-api
Contributor
Author
|
assigned reviewer seems inactive atm |
Contributor
|
r? oli is this blocked on figuring out std constification |
Contributor
|
r? oli-obk |
Collaborator
|
Failed to set assignee to
|
Contributor
|
Huh why does this affect mir-opts? I think this is fine under std constification, because it tests a very specific use case of a core type like |
oli-obk
removed
the
S-waiting-on-review
Contributor
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #157761 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#157761), which was unapproved. |
Lars-Schumann
force-pushed
the
const-array-try-from-vec
branch
from
74c398b to
123d0d1
Compare
Contributor
Author
|
Seems like rustfmt changed the keyword order for trait impls, should be good to go now. |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
constify `TryFrom<Vec>` for array
Contributor
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 16, 2026
…-vec, r=oli-obk constify `TryFrom<Vec>` for array Related issues rust-lang#79597, rust-lang#143773, rust-lang#133214 this makes `Vec` `const Destruct` along the way.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 16, 2026
…-vec, r=oli-obk constify `TryFrom<Vec>` for array Related issues rust-lang#79597, rust-lang#143773, rust-lang#133214 this makes `Vec` `const Destruct` along the way.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
…uwer Rollup of 10 pull requests Successful merges: - #155535 (export symbols: support macos/windows(32/64)) - #156538 (Refactor `AliasTy`. `AliasTerm` & `UnevaluatedConst` to use `Alias`) - #156807 (Add `T: PartialEq` bounds to derived `StructuralPartialEq` impls.) - #156950 (Staticlib rename internal symbols) - #157702 (Add expansion info to implied bounds) - #155616 (constify `TryFrom<Vec>` for array) - #156226 (diagnostics: point to coroutine body on higher-ranked auto trait errors) - #157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - #157953 (fix(rustc_codegen_ssa): Use cg_operand for Freeze check) - #157958 (doc: Document `-Zlint-rust-version`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 16, 2026
…-vec, r=oli-obk constify `TryFrom<Vec>` for array Related issues rust-lang#79597, rust-lang#143773, rust-lang#133214 this makes `Vec` `const Destruct` along the way.
This was referenced Jun 16, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
…uwer Rollup of 13 pull requests Successful merges: - #156538 (Refactor `AliasTy`. `AliasTerm` & `UnevaluatedConst` to use `Alias`) - #156807 (Add `T: PartialEq` bounds to derived `StructuralPartialEq` impls.) - #156950 (Staticlib rename internal symbols) - #156983 (Add `io::Read::read_le` and `io::Read::read_be`) - #157306 (tests: codegen-llvm: Expect the new mangling scheme in bpf-abi-indirect-return) - #157702 (Add expansion info to implied bounds) - #155616 (constify `TryFrom<Vec>` for array) - #156226 (diagnostics: point to coroutine body on higher-ranked auto trait errors) - #157870 (std: sys: solid: clamp connect_timeout tv_sec instead of truncating) - #157952 (Configure Renovate for GitHub Actions) - #157953 (fix(rustc_codegen_ssa): Use cg_operand for Freeze check) - #157958 (doc: Document `-Zlint-rust-version`) - #157974 (Rename `errors.rs` file to `diagnostics.rs` (11/N))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Related issues #79597, #143773, #133214
this makes
Vecconst Destructalong the way.