Skip to content

Rollup of 6 pull requests#157913

Merged
rust-bors[bot] merged 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-EUT1OHV
Jun 15, 2026
Merged

Rollup of 6 pull requests#157913
rust-bors[bot] merged 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-EUT1OHV

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

qaijuang and others added 14 commits June 13, 2026 14:44
* update intrinsics wrapping documentation
* fix variable names
* stabilize feature float_algebraic
* fixed algrebracis for `f16` and `f128`
…loat_algebraic, r=RalfJung

stabilize feature `float_algebraic`

Closes rust-lang#136469

Thanks to @RalfJung for getting the stabilization process started and asking me to draft the stabilization PR for the `float_algebraic` feature. This will be my first contribution to rust! I've done my best to follow the various guides for stabilization PRs, but this is my first one, so do give it a careful look. The only place left that includes "float_algebraic" is line 8202  of "src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs", but I'm assuming that's fine.
…-op-type, r=camelid

`suspicious_double_ref_op`: report unadjusted return type

`suspicious_double_ref_op` uses the adjusted expression type to distinguish a no-op call from a double-reference operation. When the result is used as another method's receiver, that type can include the parent method's receiver adjustment.

For example, `file.clone().write(&[])` reports that `clone` returns `&mut &File`, even though it returns `&File`.

This PR continues to use the adjusted type for lint classification, but now uses the method call's unadjusted type in the diagnostic. The same issue affects `.deref()`, so the regression test covers both operations.

Fixes rust-lang#146227
Update intrinsics wrapping documentation

This PR updates the documentation for `intrinsics::{wrapping_add, wrapping_sub, wrapping_mul}`,
to make it accurate for both signed and unsigned types.

Related issue: rust-lang#156726
…=Darksonn

Add Alice Ryhl to libs review rotation
… r=JonathanBrouwer

Rename `errors.rs` file to `diagnostics.rs` (10/N)

Follow-up of rust-lang#157485.

r? @JonathanBrouwer
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 15, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 15, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 46ae69c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 15, 2026
Rollup of 6 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 3fa039d (3fa039d7289f6e8e072fbd5aa643524e205ba2de, parent: b5d46ecb51c3e4134b82570cfe718f093daa6390)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2026
@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 21m 21s
Pushing 5930afc to main...

@rust-bors rust-bors Bot merged commit 5930afc into rust-lang:main Jun 15, 2026
15 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 15, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#157029 stabilize feature float_algebraic 00d6f34ab7e7e1f2d2cc1078284328b1392f13ab (link)
#157872 suspicious_double_ref_op: report unadjusted return type f2ea147516c7e341b428f9d3d24268bca7dcea17 (link)
#157877 Stabilize nonzero_from_str_radix e008f908a02d81cdd639463c2e786729e7b26c9a (link)
#157900 Update intrinsics wrapping documentation 4d42f9f7a8745dc166cfd63a4f3e5a8e9686bf99 (link)
#157904 Add Alice Ryhl to libs review rotation 0076a96ff457058b4eeaaba3c755a2fcdd605b57 (link)
#157911 Rename errors.rs file to diagnostics.rs (10/N) 85cc45a1e52a679a60bea864b0e03d0cab84ce65 (link)

previous master: 5ff740e85e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5ff740e (parent) -> 5930afc (this PR)

Test differences

Show 859 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Additionally, 858 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5930afcb1fcf96ff55af8d4b075f149b647c40a4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 19m 45s -> 8m 42s (-55.9%)
  2. dist-aarch64-linux: 1h 51m -> 2h 38m (+42.4%)
  3. dist-i686-msvc: 1h 47m -> 2h 28m (+38.1%)
  4. x86_64-gnu-pre-stabilization: 43m 51s -> 30m (-31.6%)
  5. tidy: 1m 55s -> 2m 32s (+31.2%)
  6. x86_64-rust-for-linux: 1h 7m -> 48m 16s (-28.3%)
  7. i686-gnu-nopt-1: 2h 16m -> 1h 40m (-26.2%)
  8. pr-check-1: 34m 57s -> 25m 51s (-26.1%)
  9. x86_64-msvc-ext3: 1h 51m -> 1h 26m (-22.5%)
  10. optional-x86_64-gnu-parallel-frontend: 3h -> 2h 21m (-21.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (5930afc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%, secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
-5.6% [-5.6%, -5.6%] 1
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 518.77s -> 518.611s (-0.03%)
Artifact size: 401.47 MiB -> 401.49 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants