Skip to content

Move UnusedDuplicate diag struct to rustc_attr_parsing#158023

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:move-unused-duplicate
Jun 18, 2026
Merged

Move UnusedDuplicate diag struct to rustc_attr_parsing#158023
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:move-unused-duplicate

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This was moved there in #154432, I am not entirely sure why there? This was probably an oversight, at least I missed this during review

cc @GuillaumeGomez
r? @mejrs

@rustbot

rustbot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2026

@mejrs mejrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR merged two days after #155364 😆

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d50d1db has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 17, 2026
…ate, r=mejrs

Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`

This was moved there in rust-lang#154432, I am not entirely sure why there? This was probably an oversight, at least I missed this during review

cc @GuillaumeGomez
r? @mejrs
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #157788 (Accumulate multiple -Zsanitizer target modifiers)
 - #158012 (Stabilize `strip_circumfix`)
 - #157810 (Query the trait solver in slow path for `missing_debug_implementations`)
 - #157829 (tests: adapt two tests for LLVM 23 changes)
 - #157917 (Don't suggest adding `in` to a `for` loop that already has one)
 - #157967 (Preserve track_caller for by-value dyn vtable shims)
 - #158019 (delegation: add simple test for incremental compilation)
 - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`)
rust-bors Bot pushed a commit that referenced this pull request Jun 17, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #157788 (Accumulate multiple -Zsanitizer target modifiers)
 - #158012 (Stabilize `strip_circumfix`)
 - #157810 (Query the trait solver in slow path for `missing_debug_implementations`)
 - #157829 (tests: adapt two tests for LLVM 23 changes)
 - #157873 (mips: set llvm_args -mno-check-zero-division for all mips targets)
 - #157886 (Reject extra fields in MGCA struct const arguments)
 - #157917 (Don't suggest adding `in` to a `for` loop that already has one)
 - #157967 (Preserve track_caller for by-value dyn vtable shims)
 - #158019 (delegation: add simple test for incremental compilation)
 - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`)
 - #158029 (Rename `project-stable-mir` to `project-rustc-public`)
 - #158044 (Add more tests for parallel frontend issues)
@rust-bors rust-bors Bot merged commit 0a666a9 into rust-lang:main Jun 18, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 18, 2026
rust-timer added a commit that referenced this pull request Jun 18, 2026
Rollup merge of #158023 - JonathanBrouwer:move-unused-duplicate, r=mejrs

Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`

This was moved there in #154432, I am not entirely sure why there? This was probably an oversight, at least I missed this during review

cc @GuillaumeGomez
r? @mejrs
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 18, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#157788 (Accumulate multiple -Zsanitizer target modifiers)
 - rust-lang/rust#158012 (Stabilize `strip_circumfix`)
 - rust-lang/rust#157810 (Query the trait solver in slow path for `missing_debug_implementations`)
 - rust-lang/rust#157829 (tests: adapt two tests for LLVM 23 changes)
 - rust-lang/rust#157873 (mips: set llvm_args -mno-check-zero-division for all mips targets)
 - rust-lang/rust#157886 (Reject extra fields in MGCA struct const arguments)
 - rust-lang/rust#157917 (Don't suggest adding `in` to a `for` loop that already has one)
 - rust-lang/rust#157967 (Preserve track_caller for by-value dyn vtable shims)
 - rust-lang/rust#158019 (delegation: add simple test for incremental compilation)
 - rust-lang/rust#158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`)
 - rust-lang/rust#158029 (Rename `project-stable-mir` to `project-rustc-public`)
 - rust-lang/rust#158044 (Add more tests for parallel frontend issues)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants