Rollup of 10 pull requests by JonathanBrouwer · Pull Request #158095 · rust-lang/rust

JonathanBrouwer · 2026-06-18T16:56:39Z

Successful merges:

RegionValues: disable unnecessary range check #158026 (RegionValues: disable unnecessary range check)
Handle generic reborrow in expression-use adjustment walking #156795 (Handle generic reborrow in expression-use adjustment walking)
Enhance documentation on wake call memory ordering #157694 (Enhance documentation on wake call memory ordering)
Make proc_macro::ConversionErrorKind non exhaustive #157935 (Make proc_macro::ConversionErrorKind non exhaustive)
Replace unwrap with expect in get_module_children #158002 (Replace unwrap with expect in get_module_children)
Fix reborrow source expression visits #158034 (Fix reborrow source expression visits)
Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103 #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103)
Document transient connection errors from TcpListener::accept #158074 (Document transient connection errors from TcpListener::accept)
rustdoc-json-types: Replace bincode dev-dependency with postcard #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard)
renovate: Loosen dashboard approval and adopt recommended config #158086 (renovate: Loosen dashboard approval and adopt recommended config)

* Handle generic reborrow in expression-use adjustment walking * Require generic reborrow to be terminal in adjustment walks

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Co-authored-by: Kevin Reid <kpreid@switchb.org>

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Also replicated documentation on `TyCtxt::module_children`

Co-authored-by: Timo <30553356+y21@users.noreply.github.com>

`accept` can return an error that belongs to a single incoming connection, not to the listener itself, for example a connection aborted by the peer before it could be accepted. The listener stays usable in that case, so code serving a long-lived listener usually wants to log the error and keep accepting connections rather than treat it as fatal. This was previously undocumented. - Add an `# Errors` section to `accept` that describes this behavior without listing specific error codes. - Note that `Interrupted` errors are retried internally on Unix. - Point `incoming` and `into_incoming` at `accept` for the same details.

thin-vec versions before 0.2.16 have a use-after-free / double-free in `IntoIter::drop` and `ThinVec::clear` when an element's `Drop` panics (RUSTSEC-2026-0103). The requirement now sits past the affected range.

bincode is flagged as unmaintained by RUSTSEC-2025-0141, and the advisory covers the entire crate with no patched version available. The only use in this crate was the binary serde roundtrip in the type tests. postcard (https://crates.io/crates/postcard) is a maintained serde-based binary serialization format that covers the same roundtrip testing need. bincode is still pulled in transitively by the miri subtree (via ipc-channel), which needs to be addressed upstream.

Currently, when adding liveness points to region values in the `RegionValues` struct, the locations of the points are checked for ranges. This is unnecessarily cautious because they always are in range by construction. This adds documentation (including debug assertions) to make this clearer and removes the checks, which should have a strictly positive impact on performance.

…no-range-check, r=petrochenkov `RegionValues`: disable unnecessary range check Currently, when adding liveness points to region values in the `RegionValues` struct, the locations of the points are checked for ranges. This is unnecessarily cautious because they always are in range by construction. The docstring for the method used in the checks suggests that it was designed for underlying bit sets that currently aren't used for this. This adds documentation (including debug assertions) to make this clearer and removes the checks, which should have a strictly positive impact on performance.

@aapoalas

…-visitor, r=dingxiangfei2009 Handle generic reborrow in expression-use adjustment walking Fixes an ICE in expression-use adjustment walking where `Adjust::GenericReborrow` could reach a match arm that assumed generic reborrow was unreachable. `GenericReborrow` is already emitted by typeck and classified as rvalue-producing elsewhere in `expr_use_visitor.rs`, so the adjustment walker must handle it explicitly instead of panicking. This PR models `GenericReborrow` as a borrow-like use of the source expression: - `Mutability::Mut` is treated like an exclusive/mutable reborrow use. - `Mutability::Not` is treated like a shared/coerce-shared borrow-like use. - The source is not moved or treated as a mere copy. cc @aapoalas @rustbot label F-reborrow Fixes rust-lang#156339 Tracking: rust-lang#145612

Enhance documentation on wake call memory ordering

@traviscross

…-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for rust-lang#151973. r? @traviscross

JonathanBrouwer · 2026-06-18T16:56:47Z

@bors r+ rollup=never p=5

rust-bors · 2026-06-18T16:56:50Z

📌 Commit 364f0a5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 10 pull requests Successful merges: - #158026 (`RegionValues`: disable unnecessary range check) - #156795 (Handle generic reborrow in expression-use adjustment walking) - #157694 (Enhance documentation on wake call memory ordering) - #157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - #158002 (Replace `unwrap` with `expect` in `get_module_children`) - #158034 (Fix reborrow source expression visits) - #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - #158074 (Document transient connection errors from TcpListener::accept) - #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard) - #158086 (renovate: Loosen dashboard approval and adopt recommended config)

rust-bors · 2026-06-18T17:24:30Z

💔 Test for fc3b488 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-18T17:25:43Z

@bors retry

…uwer Rollup of 10 pull requests Successful merges: - #158026 (`RegionValues`: disable unnecessary range check) - #156795 (Handle generic reborrow in expression-use adjustment walking) - #157694 (Enhance documentation on wake call memory ordering) - #157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - #158002 (Replace `unwrap` with `expect` in `get_module_children`) - #158034 (Fix reborrow source expression visits) - #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - #158074 (Document transient connection errors from TcpListener::accept) - #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard) - #158086 (renovate: Loosen dashboard approval and adopt recommended config)

rust-bors · 2026-06-18T18:01:40Z

💔 Test for 74052cc failed: CI. Failed job:

auto - armhf-gnu (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-18T18:26:59Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GuillaumeGomez · 2026-06-18T18:31:08Z

Closing in favour of #158098.

rust-bors · 2026-06-18T18:31:11Z

This pull request was unapproved due to being closed.

P8L1 and others added 30 commits May 28, 2026 16:23

Handle generic reborrow in expression-use adjustment walking

a5e4dc9

* Handle generic reborrow in expression-use adjustment walking * Require generic reborrow to be terminal in adjustment walks

Update task.rs

640d7ae

Update wake.rs

4671f48

Update wake.rs

4528827

Update library/core/src/task/wake.rs

61aa163

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Update wake.rs

c5c5e81

Update library/core/src/task/wake.rs

e65db42

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Update library/alloc/src/task.rs

16ccf8e

Co-authored-by: Kevin Reid <kpreid@switchb.org>

Update library/core/src/task/wake.rs

a0ecf25

Co-authored-by: Kevin Reid <kpreid@switchb.org>

Update wake.rs

0954d4c

Update library/core/src/task/wake.rs

42538ca

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Make proc_macro::ConversionErrorKind non exhaustive

c3fc863

Document Panic in get_module_children

d8953cd

Also replicated documentation on `TyCtxt::module_children`

fix(thir): visit reborrow source expressions

b8d7dcb

Match all fields and removing ..

a487aec

Co-authored-by: Timo <30553356+y21@users.noreply.github.com>

format reborrow visitor arm

ef672ad

Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103

7786ffc

thin-vec versions before 0.2.16 have a use-after-free / double-free in `IntoIter::drop` and `ThinVec::clear` when an element's `Drop` panics (RUSTSEC-2026-0103). The requirement now sits past the affected range.

Document the file-descriptor-limit error from TcpListener::accept

34d3eed

Document the out-of-memory error from TcpListener::accept

1447519

renovate: Skip dashboard approval for GitHub Actions updates

ebea09f

renovate: Enable monthly lock file maintenance

cfadf6e

renovate: Extend config:recommended preset

4e0bcfc

renovate: Enable config migration PRs

5db91c4

Rollup merge of rust-lang#157694 - xmh0511:main, r=Darksonn

43b2a60

Enhance documentation on wake call memory ordering

Rollup merge of rust-lang#157935 - GuillaumeGomez:ConversionErrorKind…

3ecdd65

…-non-exhaustive, r=traviscross,Mark-Simulacrum Make `proc_macro::ConversionErrorKind` non exhaustive Needed for rust-lang#151973. r? @traviscross

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026

rust-bors Bot mentioned this pull request Jun 18, 2026

RegionValues: disable unnecessary range check #158026

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2026

GuillaumeGomez closed this Jun 18, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 18, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests#158095

Rollup of 10 pull requests#158095
JonathanBrouwer wants to merge 36 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-svEIj18

JonathanBrouwer commented Jun 18, 2026

Uh oh!

JonathanBrouwer commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 18, 2026

Uh oh!

JonathanBrouwer commented Jun 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 18, 2026

Uh oh!

rust-log-analyzer commented Jun 18, 2026

Uh oh!

GuillaumeGomez commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 18, 2026

Uh oh!

JonathanBrouwer commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 18, 2026

Uh oh!

JonathanBrouwer commented Jun 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 18, 2026

Uh oh!

rust-log-analyzer commented Jun 18, 2026

Uh oh!

GuillaumeGomez commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants