-
-
Notifications
You must be signed in to change notification settings - Fork 15k
[Experiment]: Test EII for RawOsError in core
#158116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f31e466
cd28cca
7b9c41e
1e2d334
4f05853
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| //! Check that dynamic libraries can link and run now that there is an unconditional use | ||
| //! of EII in `core`. | ||
|
|
||
| //@ build-pass | ||
| //@ compile-flags: -Cpanic=abort | ||
| //@ no-prefer-dynamic | ||
| //@ needs-crate-type: dylib | ||
| #![crate_type = "dylib"] | ||
| #![feature(core_io_internals)] | ||
| #![feature(core_io)] | ||
| #![feature(raw_os_error_ty)] | ||
| #![no_std] | ||
| #![no_implicit_prelude] | ||
|
|
||
| #[panic_handler] | ||
| fn panic_handler(_info: &core::panic::PanicInfo<'_>) -> ! { | ||
| loop {} | ||
| } | ||
|
|
||
| pub use core::io::raw_os_error::*; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| //! Check that `no_std` dynamic libraries can link and run without depending on `libstd` | ||
| //! now that there is an unconditional use of EII in `core`. | ||
| //@ build-pass | ||
| //@ compile-flags: -Cpanic=abort | ||
| //@ no-prefer-dynamic | ||
| //@ needs-crate-type: dylib | ||
| #![crate_type = "dylib"] | ||
| #![feature(core_io_internals)] | ||
| #![feature(core_io)] | ||
| #![feature(raw_os_error_ty)] | ||
| #![no_std] | ||
| #![no_implicit_prelude] | ||
|
|
||
| extern crate std; | ||
|
|
||
| pub use core::io::raw_os_error::*; |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They now fail because libcore implements an EII. Crates that implement an EII are never considered unused as removing them would affect which implementation is picked for an EII or even give an error if there ie no default. That check should probably be changed to ignore the default implementation of an EII.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahhh ok. I'll update this bodge commit to note this an be a bit more surgical than just outright deleting the tests. Thanks! |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.