Skip to content

Convert '.' to '_' in bootstrap envify#158118

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ferrocene:fix-bootstrap-target-dot
Jun 19, 2026
Merged

Convert '.' to '_' in bootstrap envify#158118
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ferrocene:fix-bootstrap-target-dot

Conversation

@jonathanpallant

Copy link
Copy Markdown
Contributor

This means you can now use remote-test-client/remote-test-server with targets that contain a '.' in the name.

See #158090

r? @Kobzol

This means you can now use remote-test-client/remote-test-server
with targets that contain a '.' in the name.

See rust-lang#158090
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 19, 2026
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol

Kobzol commented Jun 19, 2026

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8ef1e86 has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 19, 2026
…, r=Kobzol

Convert '.' to '_' in bootstrap envify

This means you can now use remote-test-client/remote-test-server with targets that contain a '.' in the name.

See rust-lang#158090

r? @Kobzol
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  IMAGE: pr-check-2
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@jonathanpallant

Copy link
Copy Markdown
Contributor Author

I don't think I broke that?

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@Kobzol

Kobzol commented Jun 19, 2026

Copy link
Copy Markdown
Member

Yeah that is transient, not related to this PR.

rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@rust-bors rust-bors Bot merged commit 4c7560c into rust-lang:main Jun 19, 2026
2 of 13 checks passed
rust-timer added a commit that referenced this pull request Jun 19, 2026
Rollup merge of #158118 - ferrocene:fix-bootstrap-target-dot, r=Kobzol

Convert '.' to '_' in bootstrap envify

This means you can now use remote-test-client/remote-test-server with targets that contain a '.' in the name.

See #158090

r? @Kobzol
@rustbot rustbot added this to the 1.98.0 milestone Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants