Skip to content

ensure the new solver bootstraps on CI#158129

Open
lqd wants to merge 2 commits into
rust-lang:mainfrom
lqd:bootstrap-new-solver
Open

ensure the new solver bootstraps on CI#158129
lqd wants to merge 2 commits into
rust-lang:mainfrom
lqd:bootstrap-new-solver

Conversation

@lqd

@lqd lqd commented Jun 19, 2026

Copy link
Copy Markdown
Member

With #158040, the new solver should now be able to bootstrap, and this PR ensures on CI it doesn't regress. This is part of the plan in #157780 until stabilization.

This renames the job as well to something hopefully clearer, from x86_64-gnu-pre-stabilization to x86_64-gnu-next-trait-solver-polonius. And thus, also needs rust-lang/rustc-dev-guide#2904 to have the correct doc_url.

r? kobzol

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 19, 2026
@Kobzol

Kobzol commented Jun 19, 2026

Copy link
Copy Markdown
Member

What a great opportunity to rename the job to x86_64-gnu-new-trait-solver-polonius 😈

@lqd

lqd commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

58 minutes for the first run, 57 minutes for the second, not bad.

It's not the slowest job either, and testing stage 2 didn't seem to change the duration noticeable.

#158040 landed, so I'll rebase and push for a 3rd CI run, and then this should be ready to go.

@lqd lqd force-pushed the bootstrap-new-solver branch from b7cef46 to c390ede Compare June 19, 2026 14:53
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

kobzol is not on the review rotation at the moment.
They may take a while to respond.

@lqd lqd marked this pull request as ready for review June 19, 2026 14:57
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2026
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 19, 2026
@Kobzol

Kobzol commented Jun 19, 2026

Copy link
Copy Markdown
Member

Looks good, thanks!

@bors r+

@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c390ede has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 19, 2026
ensure the new solver bootstraps on CI

With rust-lang#158040, the new solver should now be able to bootstrap, and this PR ensures on CI it doesn't regress. This is part of the plan in rust-lang#157780 until stabilization.

This renames the job as well to something hopefully clearer, from `x86_64-gnu-pre-stabilization` to `x86_64-gnu-next-trait-solver-polonius`. And thus, also needs rust-lang/rustc-dev-guide#2904 to have the correct `doc_url`.

r? kobzol
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 19, 2026
ensure the new solver bootstraps on CI

With rust-lang#158040, the new solver should now be able to bootstrap, and this PR ensures on CI it doesn't regress. This is part of the plan in rust-lang#157780 until stabilization.

This renames the job as well to something hopefully clearer, from `x86_64-gnu-pre-stabilization` to `x86_64-gnu-next-trait-solver-polonius`. And thus, also needs rust-lang/rustc-dev-guide#2904 to have the correct `doc_url`.

r? kobzol
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #158129 (ensure the new solver bootstraps on CI)
 - #158134 (Rename `lint-rust-version` to `hint-msrv`)
 - #157926 (Implement `#[diagnostic::on_unknown]` for modules.)
 - #158075 (Point to the unstable segment of an import path instead of to the whole path)
 - #158084 (`-Znext-solver` Emit error instead of ICE when combining {int, float} var with alias)
 - #158128 (std: use correct low surrogate range in Windows standard I/O code)
 - #158132 (std: correctly report file size on UWP)
 - #158138 (Remove redundant check for `#[loop_match]` and `#[const_continue]`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants