Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/config/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,17 @@ pub enum Heuristics {
}

impl Density {
pub fn to_list_tactic(self, len: usize) -> ListTactic {
pub fn to_list_tactic(self, style_edition: StyleEdition, len: usize) -> ListTactic {
match self {
Density::Compressed => ListTactic::Mixed,
Density::Tall => ListTactic::HorizontalVertical,
Density::Vertical if len == 1 => ListTactic::Horizontal,
Comment thread
jasonaowen marked this conversation as resolved.
Density::Vertical if len == 1 => {
if style_edition <= StyleEdition::Edition2024 {
ListTactic::Horizontal
} else {
ListTactic::HorizontalVertical
}
}
Density::Vertical => ListTactic::Vertical,
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2877,7 +2877,7 @@ fn rewrite_params(
context
.config
.fn_params_layout()
.to_list_tactic(param_items.len()),
.to_list_tactic(context.config.style_edition(), param_items.len()),
Separator::Comma,
one_line_budget,
);
Expand Down
22 changes: 22 additions & 0 deletions tests/source/configs/fn_params_layout/vertical.rs
Comment thread
jasonaowen marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
// Function arguments density

trait Lorem {
fn lorem(ipsum: Ipsum);

fn lorem(ipsum: Ipsum) -> Dolor;

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet);

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet) {
Expand All @@ -13,4 +17,22 @@ trait Lorem {
fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet, consectetur: onsectetur, adipiscing: Adipiscing, elit: Elit) {
// body
}

fn long_param_name(lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod: Tempor);

fn long_param_type(lorem: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore,
);

fn long_return_type(lorem: Lorem)
-> IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore;

fn lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod_tempor_incididunt
(lorem: Lorem);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEt>(t: T);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEtDolore>
(
t: T,
);
}
39 changes: 39 additions & 0 deletions tests/source/configs/fn_params_layout/vertical_style_2027.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// rustfmt-style_edition: 2027
// rustfmt-fn_params_layout: Vertical
// Function arguments density

trait Lorem {
fn lorem(ipsum: Ipsum);

fn lorem(ipsum: Ipsum) -> Dolor;

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet);

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet) {
// body
}

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet, consectetur: onsectetur, adipiscing: Adipiscing, elit: Elit);

fn lorem(ipsum: Ipsum, dolor: Dolor, sit: Sit, amet: Amet, consectetur: onsectetur, adipiscing: Adipiscing, elit: Elit) {
// body
}

fn long_param_name(lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod: Tempor);

fn long_param_type(lorem: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore,
);

fn long_return_type(lorem: Lorem)
-> IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore;

fn lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod_tempor_incididunt
(lorem: Lorem);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEt>(t: T);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEtDolore>
(
t: T,
);
}
30 changes: 30 additions & 0 deletions tests/target/configs/fn_params_layout/vertical.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
// Function arguments density

trait Lorem {
fn lorem(ipsum: Ipsum);

fn lorem(ipsum: Ipsum) -> Dolor;

fn lorem(
ipsum: Ipsum,
dolor: Dolor,
Expand Down Expand Up @@ -39,4 +43,30 @@ trait Lorem {
) {
// body
}

fn long_param_name(
lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod: Tempor
);

fn long_param_type(
lorem: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore
);

fn long_return_type(
lorem: Lorem
) -> IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore;

fn lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod_tempor_incididunt(
lorem: Lorem
);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEt>(
t: T
);

fn lorem<
T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEtDolore,
>(
t: T
);
}
73 changes: 73 additions & 0 deletions tests/target/configs/fn_params_layout/vertical_style_2027.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// rustfmt-style_edition: 2027
// rustfmt-fn_params_layout: Vertical
// Function arguments density

trait Lorem {
fn lorem(ipsum: Ipsum);

fn lorem(ipsum: Ipsum) -> Dolor;

fn lorem(
ipsum: Ipsum,
dolor: Dolor,
sit: Sit,
amet: Amet,
);

fn lorem(
ipsum: Ipsum,
dolor: Dolor,
sit: Sit,
amet: Amet,
) {
// body
}

fn lorem(
ipsum: Ipsum,
dolor: Dolor,
sit: Sit,
amet: Amet,
consectetur: onsectetur,
adipiscing: Adipiscing,
elit: Elit,
);

fn lorem(
ipsum: Ipsum,
dolor: Dolor,
sit: Sit,
amet: Amet,
consectetur: onsectetur,
adipiscing: Adipiscing,
elit: Elit,
) {
// body
}

fn long_param_name(
lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod: Tempor,
);

fn long_param_type(
lorem: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore,
);

fn long_return_type(
lorem: Lorem,
) -> IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLabore;

fn lorem_ipsum_dolor_sit_amet_consectetur_adipiscing_elit_sed_do_eiusmod_tempor_incididunt(
lorem: Lorem,
);

fn lorem<T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEt>(
t: T,
);

fn lorem<
T: IpsumDolorSitAmetConsecteturAdipiscingElitSedDoEiusmodTemporIncididuntUtLaboreEtDolore,
>(
t: T,
);
}
Loading