Add extra_cargo_args support for prepare phase#119
Open
enthropy7 wants to merge 2 commits into
Open
Conversation
syphar
requested changes
Apr 7, 2026
Member
syphar
left a comment
syphar
left a comment
There was a problem hiding this comment.
Thanks!
This is missing tests.
we have "integration-like" tests / examples in tests/.
enthropy7
force-pushed
the
extra-cargo-args
branch
from
a2b241d to
fa3e5b1
Compare
Author
|
added and tested :) |
Member
I realized that I totally missed this comment, and in my "reviews requested" this PR didn't pop up. Will recheck. ( generally: I did "some" refactoring in the codebase that means you need to update this PR too |
Test that extra cargo args are forwarded to cargo during the prepare phase: a positive test with --quiet and a negative test with an invalid flag to prove args are actually passed through.
enthropy7
force-pushed
the
extra-cargo-args
branch
from
fa3e5b1 to
406271e
Compare
Author
|
done! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds an
extra_cargo_args()method toBuildBuilderthat forwards extra arguments to all cargo commands duringPrepare::prepare():validate_manifest,capture_lockfile, andfetch_deps. without this, crates that require unstable cargo flags for manifest parsing (e.g.-Zbindepsfor artifact dependencies) fail at the prepare phase withInvalidCargoTomlSyntax, because there's no way for callers to pass these flags.needed by docs.rs: rust-lang/docs.rs#3111