intrinsic-test: sve type parsing and constraints#2121
Merged
Conversation
Collaborator
|
r? @adamgemmell rustbot has assigned @adamgemmell. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
intrinsic-test-sve-types
branch
from
4e0895e to
ccc9b59
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
`ArmIntrinsicType` does not need a `target` field and `parse_intrinsic_type` can be a free function that returns an `IntrinsicType` which can be wrapped in an `ArmIntrinsicType` by the caller.
davidtwco
force-pushed
the
intrinsic-test-sve-types
branch
from
ccc9b59 to
f91b183
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
adamgemmell
requested changes
May 20, 2026
Updates `parse_intrinsic_type` to support SVE intrinsic types, with the limited changes required to `IntrinsicType` and relevant users of the `simd_len` to preserve existing behaviour, assuming the tool never attempts to generate tests for SVE intrinsics (which it doesn't yet)
davidtwco
force-pushed
the
intrinsic-test-sve-types
branch
from
f91b183 to
a009d5d
Compare
adamgemmell
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First initial changes for SVE support in
intrinsic-test:ArmIntrinsicType, removing the unusedtargetfieldparse_intrinsic_typeto be able to parse SVE types, updatingsimd_lento be able to represent bothScalableandFixed(u32)length vectors, with minimal changes to keep the users of this field working even if they'll need further changes to actually support theScalablecase properlyConstraintto support additional constraint kinds that we'll want to test for SVE, and adds logic to insert these constraints where appropriate.This patch doesn't actually test any SVE intrinsics yet, so none of this additional logic is hit yet, but I've confirmed that it does the right things locally when the filter for Neon intrinsics is removed.