Skip to content

cursor-icon version 1.0.0#2

Merged
kchibisov merged 1 commit into
rust-windowing:mainfrom
kchibisov:release-1.0.0
May 9, 2023
Merged

cursor-icon version 1.0.0#2
kchibisov merged 1 commit into
rust-windowing:mainfrom
kchibisov:release-1.0.0

Conversation

@kchibisov

Copy link
Copy Markdown
Member

@madsmtm

madsmtm commented May 8, 2023

Copy link
Copy Markdown
Member

Let's add a no-op alloc feature first, something like:

[features]
default = ["std"]
std = ["alloc"]
alloc = []
// For forwards compatibility
#[cfg(feature = "alloc")]
extern crate alloc as _;

Details.

@kchibisov

kchibisov commented May 8, 2023

Copy link
Copy Markdown
Member Author

But adding a feature is not a breaking change?

Haven't noticed your link.

@kchibisov

Copy link
Copy Markdown
Member Author

@madsmtm done in b384d99

@kchibisov

kchibisov commented May 8, 2023

Copy link
Copy Markdown
Member Author

Adding aliases is not justified, see https://www.freedesktop.org/wiki/Specifications/cursor-spec/ . There's a movement to use standard icon names, so we can keep everything the way it is. And most cursor themes have all the variants listed in that spec already.

@notgull notgull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the API Guidelines Checklist and made PRs for the things I found missing. Aside from that, looks good to me!

@notgull notgull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@i509VCB

i509VCB commented May 8, 2023

Copy link
Copy Markdown

I'll mention this from matrix given that went into legal off topic:

Should we include documentation for CursorIcon::from_str to specify what string values are expected. I'd guess it's the CSS values from quickly searching?

@kchibisov

Copy link
Copy Markdown
Member Author

Should we include documentation for CursorIcon::from_str to specify what string values are expected. I'd guess it's the CSS values from quickly searching?

Done in 92dd3e6

@kchibisov kchibisov merged commit 108c2a1 into rust-windowing:main May 9, 2023
@kchibisov kchibisov deleted the release-1.0.0 branch May 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants