fix: use shared "AQL: Extensions" panel for inherited queries - #178
Open
ryanwelcher wants to merge 1 commit into
Open
fix: use shared "AQL: Extensions" panel for inherited queries#178ryanwelcher wants to merge 1 commit into
ryanwelcher wants to merge 1 commit into
Conversation
Inherited queries always rendered an empty "Advanced Query Settings" panel ahead of the built-in panels. Extract a single ExtensionsPanel used by both branches so extensions render in the same trailing "AQL: Extensions" panel, only when a fill is registered. Fixes #177 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018hshEoBHWTf326ViYno6g2
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, low-risk UI refactor that matches the documented expected behavior and removes an always-visible empty panel without altering query logic.
Pull request overview
This PR fixes the inherited-query editor UX for Advanced Query Loop by consolidating third‑party SlotFill rendering into the same conditional trailing “AQL: Extensions” panel used for non-inherited queries, eliminating an always-visible empty panel.
Changes:
- Extracts a shared
ExtensionsPanelcomponent that renders only when SlotFills exist, and reuses it for both inherited and non-inherited query modes. - Removes the inherited-mode “Advanced Query Settings” wrapper panel and relocates
AQLControlsInheritedQueryfills to the trailing “AQL: Extensions” panel. - Updates developer/docs references and the 5.0.0 changelog entry to match the new panel behavior.
File summaries
| File | Description |
|---|---|
| src/variations/controls.js | Adds shared ExtensionsPanel and uses it for both inherited and non-inherited SlotFill rendering, removing the empty inherited panel. |
| readme.txt | Notes the inherited-query UI change in the 5.0.0 changelog. |
| extending-aql.md | Updates extension documentation to reflect the shared trailing “AQL: Extensions” panel behavior. |
| CLAUDE.md | Updates architecture documentation to reflect the inherited-query extensions panel behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177
Summary
ExtensionsPanelcomponent (aPanelBodytitled "AQL: Extensions" that renders nothing when no fills are registered) and use it in both the custom and inherited branches ofsrc/variations/controls.js.AQLControlsInheritedQueryfills now render in the trailing "AQL: Extensions" panel after "AQL: Order by" and "AQL: Advanced", matching custom queries.CLAUDE.md,extending-aql.md, and the 5.0.0 changelog inreadme.txt.Test plan
AQLControlsInheritedQueryfill: an "AQL: Extensions" panel appears last, after "AQL: Advanced".AQLControlsfill: the trailing "AQL: Extensions" panel behaves as before.npm run lint:jsandnpm run buildpass.🤖 Generated with Claude Code
https://claude.ai/code/session_018hshEoBHWTf326ViYno6g2