Handle scientific notation numbers - #444
Open
yhnavein wants to merge 4 commits into
Open
Conversation
added unit tests to prove it does the work chore: added vscode config that won't break anything in this project
chore: do not include dev files in npm package
yhnavein
force-pushed
the
fix/scientific-notations
branch
from
February 13, 2021 16:38
4d612c6 to
77ea545
Compare
Author
|
Bumping topic... |
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added unit tests to prove it does the work
chore: added vscode config that won't break anything in this project
The reason I did this change is that before when I was formatting small numbers I was seeing huge numbers instead. Take a look:
would render
5 000 000.000for some strange reason. Apparently numbers given in a scientific notation are handled very poorly.I've added a simple support for scientific notation to the NumberFormat component and now it looks much better.
BTW - I've added very simple VSCode config so that it won't prettify whole files on save.