Skip to content

feat(sdds-finai): add Editable component - #3132

Draft
Yeti-or wants to merge 1 commit into
devfrom
feat/sdds-finai-editable
Draft

Yeti-or wants to merge 1 commit into
devfrom
feat/sdds-finai-editable

Conversation

@Yeti-or

@Yeti-or Yeti-or commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

SDDS-FINAI

Editable

  • added themed Editable wrapper over plasma-new-hope
  • added Storybook story
  • added Cypress test scaffolds (component-test + update-test)

What/why changed

Editable was available in plasma-web/b2c but missing from sdds-finai. This adds the final-package wiring with finai theme tokens so the component can be used from @salutejs/sdds-finai.

TODO before review

  • Needs Cypress visual tests / snapshots — test files are present, but snapshots were not generated locally (CYPRESS_updateSnapshots still required)
  • Verify tests pass in CI after snapshots are added

Made with Cursor

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.393.0-canary.3132.33758896534.0
npm install @salutejs/plasma-b2c@1.635.0-canary.3132.33758896534.0
npm install @salutejs/plasma-colors@0.23.0-canary.3132.33758896534.0
npm install @salutejs/plasma-core@1.242.0-canary.3132.33758896534.0
npm install @salutejs/plasma-giga@0.362.0-canary.3132.33758896534.0
npm install @salutejs/plasma-homeds@0.362.0-canary.3132.33758896534.0
npm install @salutejs/plasma-hope@1.389.0-canary.3132.33758896534.0
npm install @salutejs/plasma-icons@1.250.0-canary.3132.33758896534.0
npm install @salutejs/plasma-new-hope@0.379.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens@1.153.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens-b2b@1.66.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens-b2c@0.77.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens-core@0.14.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens-web@1.81.0-canary.3132.33758896534.0
npm install @salutejs/plasma-typo@0.54.0-canary.3132.33758896534.0
npm install @salutejs/plasma-web@1.637.0-canary.3132.33758896534.0
npm install @salutejs/sdds-bizcom@0.367.0-canary.3132.33758896534.0
npm install @salutejs/sdds-cs@0.371.0-canary.3132.33758896534.0
npm install @salutejs/sdds-dfa@0.365.0-canary.3132.33758896534.0
npm install @salutejs/sdds-finai@0.358.0-canary.3132.33758896534.0
npm install @salutejs/sdds-icons@0.7.0-canary.3132.33758896534.0
npm install @salutejs/sdds-insol@0.362.0-canary.3132.33758896534.0
npm install @salutejs/sdds-insol-next@0.361.0-canary.3132.33758896534.0
npm install @salutejs/sdds-netology@0.366.0-canary.3132.33758896534.0
npm install @salutejs/sdds-os@0.37.0-canary.3132.33758896534.0
npm install @salutejs/sdds-platform-ai@0.366.0-canary.3132.33758896534.0
npm install @salutejs/sdds-sbcom@0.367.0-canary.3132.33758896534.0
npm install @salutejs/sdds-scan@0.365.0-canary.3132.33758896534.0
npm install @salutejs/sdds-serv@0.366.0-canary.3132.33758896534.0
npm install @salutejs/core-themes@0.42.0-canary.3132.33758896534.0
npm install @salutejs/plasma-themes@0.64.0-canary.3132.33758896534.0
npm install @salutejs/sdds-themes@0.80.0-canary.3132.33758896534.0
npm install @salutejs/sdds-api-tests@0.24.0-canary.3132.33758896534.0
npm install @salutejs/plasma-cy-utils@0.172.0-canary.3132.33758896534.0
npm install @salutejs/plasma-sb-utils@0.243.0-canary.3132.33758896534.0
npm install @salutejs/plasma-tokens-utils@0.62.0-canary.3132.33758896534.0
# or 
yarn add @salutejs/plasma-asdk@0.393.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-b2c@1.635.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-colors@0.23.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-core@1.242.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-giga@0.362.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-homeds@0.362.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-hope@1.389.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-icons@1.250.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-new-hope@0.379.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens@1.153.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens-b2b@1.66.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens-b2c@0.77.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens-core@0.14.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens-web@1.81.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-typo@0.54.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-web@1.637.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-bizcom@0.367.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-cs@0.371.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-dfa@0.365.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-finai@0.358.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-icons@0.7.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-insol@0.362.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-insol-next@0.361.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-netology@0.366.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-os@0.37.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-platform-ai@0.366.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-sbcom@0.367.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-scan@0.365.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-serv@0.366.0-canary.3132.33758896534.0
yarn add @salutejs/core-themes@0.42.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-themes@0.64.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-themes@0.80.0-canary.3132.33758896534.0
yarn add @salutejs/sdds-api-tests@0.24.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-cy-utils@0.172.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-sb-utils@0.243.0-canary.3132.33758896534.0
yarn add @salutejs/plasma-tokens-utils@0.62.0-canary.3132.33758896534.0

Wire Editable from plasma-new-hope with finai tokens and Storybook.
Cypress scaffolds are included; visual snapshots still need generation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3132/

This branch was previously deployed

1 inactive deployment
internal — 26526651 Deployed Sep 3, 2026 by Yeti-or via Authorize external pull request / Approved #11484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant