Conversation
Allow consumers to sort dropdown items via sortItems. Sorting runs when the list opens and stays frozen while open so nested menus do not jump on selection. Examples added for sdds-finai (flat and nested). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3140/ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core
Combobox
sortItemsдля кастомной сортировки элементов после фильтрацииvalueдля стабильности при сортировкеSDDS-FINAI
Combobox
Custom SortиCustom Sort Nested(multiple + chips, выбранные сверху)What/why changed
Веб-инженеры уже могли кастомизировать фильтрацию через
filter. Нужен аналогичный API для сортировки — например, поднимать выбранные chips вверх списка. Для nested-элементов сортировка «на лету» ломает UX каскадных меню, поэтомуsortItemsвызывается только при открытии списка.Made with Cursor
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.393.0-canary.3140.33875275234.0 npm install @salutejs/plasma-b2c@1.635.0-canary.3140.33875275234.0 npm install @salutejs/plasma-colors@0.23.0-canary.3140.33875275234.0 npm install @salutejs/plasma-core@1.242.0-canary.3140.33875275234.0 npm install @salutejs/plasma-giga@0.362.0-canary.3140.33875275234.0 npm install @salutejs/plasma-homeds@0.362.0-canary.3140.33875275234.0 npm install @salutejs/plasma-hope@1.389.0-canary.3140.33875275234.0 npm install @salutejs/plasma-icons@1.250.0-canary.3140.33875275234.0 npm install @salutejs/plasma-new-hope@0.379.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens@1.153.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens-b2b@1.66.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens-b2c@0.77.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens-core@0.14.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens-web@1.81.0-canary.3140.33875275234.0 npm install @salutejs/plasma-typo@0.54.0-canary.3140.33875275234.0 npm install @salutejs/plasma-web@1.637.0-canary.3140.33875275234.0 npm install @salutejs/sdds-bizcom@0.367.0-canary.3140.33875275234.0 npm install @salutejs/sdds-cs@0.371.0-canary.3140.33875275234.0 npm install @salutejs/sdds-dfa@0.365.0-canary.3140.33875275234.0 npm install @salutejs/sdds-finai@0.358.0-canary.3140.33875275234.0 npm install @salutejs/sdds-icons@0.7.0-canary.3140.33875275234.0 npm install @salutejs/sdds-insol@0.362.0-canary.3140.33875275234.0 npm install @salutejs/sdds-insol-next@0.361.0-canary.3140.33875275234.0 npm install @salutejs/sdds-netology@0.366.0-canary.3140.33875275234.0 npm install @salutejs/sdds-os@0.37.0-canary.3140.33875275234.0 npm install @salutejs/sdds-platform-ai@0.366.0-canary.3140.33875275234.0 npm install @salutejs/sdds-sbcom@0.367.0-canary.3140.33875275234.0 npm install @salutejs/sdds-scan@0.365.0-canary.3140.33875275234.0 npm install @salutejs/sdds-serv@0.366.0-canary.3140.33875275234.0 npm install @salutejs/core-themes@0.42.0-canary.3140.33875275234.0 npm install @salutejs/plasma-themes@0.64.0-canary.3140.33875275234.0 npm install @salutejs/sdds-themes@0.80.0-canary.3140.33875275234.0 npm install @salutejs/sdds-api-tests@0.24.0-canary.3140.33875275234.0 npm install @salutejs/plasma-cy-utils@0.172.0-canary.3140.33875275234.0 npm install @salutejs/plasma-sb-utils@0.243.0-canary.3140.33875275234.0 npm install @salutejs/plasma-tokens-utils@0.62.0-canary.3140.33875275234.0 # or yarn add @salutejs/plasma-asdk@0.393.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-b2c@1.635.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-colors@0.23.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-core@1.242.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-giga@0.362.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-homeds@0.362.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-hope@1.389.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-icons@1.250.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-new-hope@0.379.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens@1.153.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens-b2b@1.66.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens-b2c@0.77.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens-core@0.14.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens-web@1.81.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-typo@0.54.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-web@1.637.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-bizcom@0.367.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-cs@0.371.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-dfa@0.365.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-finai@0.358.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-icons@0.7.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-insol@0.362.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-insol-next@0.361.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-netology@0.366.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-os@0.37.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-platform-ai@0.366.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-sbcom@0.367.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-scan@0.365.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-serv@0.366.0-canary.3140.33875275234.0 yarn add @salutejs/core-themes@0.42.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-themes@0.64.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-themes@0.80.0-canary.3140.33875275234.0 yarn add @salutejs/sdds-api-tests@0.24.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-cy-utils@0.172.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-sb-utils@0.243.0-canary.3140.33875275234.0 yarn add @salutejs/plasma-tokens-utils@0.62.0-canary.3140.33875275234.0