Skip to content

PLASMA-8064: secondary Button hover color - #3150

Merged
vmytnik merged 1 commit into
devfrom
PLASMA-8064.giga-button-hover-color
Sep 14, 2026
Merged

vmytnik merged 1 commit into
devfrom
PLASMA-8064.giga-button-hover-color

Conversation

@vmytnik

@vmytnik vmytnik commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

PLASMA-GIGA

Button, IconButton

  • цвет ховера для view secondary согласно макету

What/why changed

  • цвет ховера для view secondary согласно макету

Summary by CodeRabbit

  • Style
    • Updated hover styling for secondary buttons and icon buttons to use the tertiary transparent surface color.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.392.1-canary.3150.34216220865.0
npm install @salutejs/plasma-b2c@1.634.1-canary.3150.34216220865.0
npm install @salutejs/plasma-colors@0.22.1-canary.3150.34216220865.0
npm install @salutejs/plasma-core@1.241.1-canary.3150.34216220865.0
npm install @salutejs/plasma-giga@0.361.1-canary.3150.34216220865.0
npm install @salutejs/plasma-homeds@0.361.1-canary.3150.34216220865.0
npm install @salutejs/plasma-hope@1.388.1-canary.3150.34216220865.0
npm install @salutejs/plasma-icons@1.249.1-canary.3150.34216220865.0
npm install @salutejs/plasma-new-hope@0.378.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens@1.152.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens-b2b@1.65.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens-b2c@0.76.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens-core@0.13.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens-web@1.80.1-canary.3150.34216220865.0
npm install @salutejs/plasma-typo@0.53.1-canary.3150.34216220865.0
npm install @salutejs/plasma-web@1.636.1-canary.3150.34216220865.0
npm install @salutejs/sdds-bizcom@0.366.1-canary.3150.34216220865.0
npm install @salutejs/sdds-cs@0.370.1-canary.3150.34216220865.0
npm install @salutejs/sdds-dfa@0.364.1-canary.3150.34216220865.0
npm install @salutejs/sdds-finai@0.357.1-canary.3150.34216220865.0
npm install @salutejs/sdds-icons@0.6.1-canary.3150.34216220865.0
npm install @salutejs/sdds-insol@0.361.1-canary.3150.34216220865.0
npm install @salutejs/sdds-insol-next@0.360.1-canary.3150.34216220865.0
npm install @salutejs/sdds-netology@0.365.1-canary.3150.34216220865.0
npm install @salutejs/sdds-os@0.36.1-canary.3150.34216220865.0
npm install @salutejs/sdds-platform-ai@0.365.1-canary.3150.34216220865.0
npm install @salutejs/sdds-sbcom@0.366.1-canary.3150.34216220865.0
npm install @salutejs/sdds-scan@0.364.1-canary.3150.34216220865.0
npm install @salutejs/sdds-serv@0.365.1-canary.3150.34216220865.0
npm install @salutejs/core-themes@0.41.1-canary.3150.34216220865.0
npm install @salutejs/plasma-themes@0.63.1-canary.3150.34216220865.0
npm install @salutejs/sdds-themes@0.79.1-canary.3150.34216220865.0
npm install @salutejs/sdds-api-tests@0.23.1-canary.3150.34216220865.0
npm install @salutejs/plasma-cy-utils@0.171.1-canary.3150.34216220865.0
npm install @salutejs/plasma-sb-utils@0.242.1-canary.3150.34216220865.0
npm install @salutejs/plasma-tokens-utils@0.61.1-canary.3150.34216220865.0
# or 
yarn add @salutejs/plasma-asdk@0.392.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-b2c@1.634.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-colors@0.22.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-core@1.241.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-giga@0.361.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-homeds@0.361.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-hope@1.388.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-icons@1.249.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-new-hope@0.378.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens@1.152.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens-b2b@1.65.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens-b2c@0.76.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens-core@0.13.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens-web@1.80.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-typo@0.53.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-web@1.636.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-bizcom@0.366.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-cs@0.370.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-dfa@0.364.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-finai@0.357.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-icons@0.6.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-insol@0.361.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-insol-next@0.360.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-netology@0.365.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-os@0.36.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-platform-ai@0.365.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-sbcom@0.366.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-scan@0.364.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-serv@0.365.1-canary.3150.34216220865.0
yarn add @salutejs/core-themes@0.41.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-themes@0.63.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-themes@0.79.1-canary.3150.34216220865.0
yarn add @salutejs/sdds-api-tests@0.23.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-cy-utils@0.171.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-sb-utils@0.242.1-canary.3150.34216220865.0
yarn add @salutejs/plasma-tokens-utils@0.61.1-canary.3150.34216220865.0

…[PLASMA-8064]

Use Surfaces/Default/Transparent/Tertiary for Button and IconButton secondary hover.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3150/

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0863fe9f-9edc-4137-9ee5-edd56633254f

📥 Commits

Reviewing files that changed from the base of the PR and between d270c15 and bee1253.

📒 Files selected for processing (2)
  • packages/plasma-giga/src/components/Button/Button.config.ts
  • packages/plasma-giga/src/components/IconButton/IconButton.config.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

The plasma-giga theme now uses surfaceTransparentTertiary for secondary hover backgrounds in Button and IconButton.

Secondary hover token updates

Layer / File(s) Summary
Secondary hover token wiring
packages/plasma-giga/src/components/Button/Button.config.ts, packages/plasma-giga/src/components/IconButton/IconButton.config.ts
Both configurations import surfaceTransparentTertiary and use it for the secondary hover background.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bee12

Secondary Button and IconButton hover backgrounds now use the specified tertiary transparent surface token. The change is consistent across both components and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the secondary Button hover color change. It does not mention IconButton, but it remains specific and accurately describes a primary part of the changeset.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PLASMA-8064.giga-button-hover-color

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-3150/
giga storybook: https://plasma.sberdevices.ru/pr/pr-3150/giga-storybook/

@Yakutoc
Yakutoc requested review from Irinkv and Yakutoc and removed request for TitanKuzmich, Yakutoc, Yeti-or, neretin-trike and shuga2704 September 8, 2026 11:14
@Yakutoc
Yakutoc requested review from TitanKuzmich and luizasok and removed request for Irinkv and Yakutoc September 8, 2026 11:14
@IgorYar
IgorYar self-requested a review September 11, 2026 10:31
@vmytnik
vmytnik added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 14, 2026
@vmytnik
vmytnik added this pull request to the merge queue Sep 14, 2026
Merged via the queue into dev with commit 1a4fd0d Sep 14, 2026
22 checks passed
@vmytnik
vmytnik deleted the PLASMA-8064.giga-button-hover-color branch September 14, 2026 09:00
@github-actions

Copy link
Copy Markdown
Contributor

This PR is included in version:

  • @salutejs/plasma-asdk@0.394.0
  • @salutejs/plasma-b2c@1.636.0
  • @salutejs/plasma-colors@0.23.0
  • @salutejs/plasma-core@1.243.0
  • @salutejs/plasma-giga@0.363.0
  • @salutejs/plasma-homeds@0.363.0
  • @salutejs/plasma-hope@1.390.0
  • @salutejs/plasma-icons@1.250.0
  • @salutejs/plasma-new-hope@0.380.0
  • @salutejs/plasma-tokens@1.154.0
  • @salutejs/plasma-tokens-b2b@1.66.0
  • @salutejs/plasma-tokens-b2c@0.77.0
  • @salutejs/plasma-tokens-core@0.14.0
  • @salutejs/plasma-tokens-web@1.81.0
  • @salutejs/plasma-typo@0.54.0
  • @salutejs/plasma-web@1.638.0
  • @salutejs/sdds-bizcom@0.368.0
  • @salutejs/sdds-cs@0.372.0
  • @salutejs/sdds-dfa@0.366.0
  • @salutejs/sdds-finai@0.359.0
  • @salutejs/sdds-icons@0.8.0
  • @salutejs/sdds-insol@0.363.0
  • @salutejs/sdds-insol-next@0.362.0
  • @salutejs/sdds-netology@0.367.0
  • @salutejs/sdds-os@0.38.0
  • @salutejs/sdds-platform-ai@0.367.0
  • @salutejs/sdds-sbcom@0.368.0
  • @salutejs/sdds-scan@0.366.0
  • @salutejs/sdds-serv@0.367.0
  • @salutejs/sdds-vc@0.2.0
  • @salutejs/core-themes@0.42.0
  • @salutejs/plasma-themes@0.64.0
  • @salutejs/sdds-themes@0.81.0
  • @salutejs/sdds-api-tests@0.25.0
  • @salutejs/plasma-cy-utils@0.173.0
  • @salutejs/plasma-sb-utils@0.244.0
  • @salutejs/plasma-tokens-utils@0.62.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants