PLASMA-8115: Dropdown item border-radius with container by vmytnik · Pull Request #3152 · salute-developers/plasma

vmytnik · 2026-09-08T13:12:11Z

PLASMA-GIGA

Dropdown

обрезались скругления при ховере на элемент. добавлен токен для внутреннего border-radius списка

What/why changed

обрезались скругления при ховере на элемент. добавлен токен для внутреннего border-radius списка

Summary by CodeRabbit

Style
- Updated dropdown item corner rounding across all size variations for a more consistent appearance.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.392.2-canary.3152.34475910927.0
npm install @salutejs/plasma-b2c@1.634.2-canary.3152.34475910927.0
npm install @salutejs/plasma-colors@0.22.1-canary.3152.34475910927.0
npm install @salutejs/plasma-core@1.241.2-canary.3152.34475910927.0
npm install @salutejs/plasma-giga@0.361.2-canary.3152.34475910927.0
npm install @salutejs/plasma-homeds@0.361.2-canary.3152.34475910927.0
npm install @salutejs/plasma-hope@1.388.2-canary.3152.34475910927.0
npm install @salutejs/plasma-icons@1.249.1-canary.3152.34475910927.0
npm install @salutejs/plasma-new-hope@0.378.2-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens@1.152.1-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens-b2b@1.65.1-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens-b2c@0.76.1-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens-core@0.13.1-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens-web@1.80.1-canary.3152.34475910927.0
npm install @salutejs/plasma-typo@0.53.1-canary.3152.34475910927.0
npm install @salutejs/plasma-web@1.636.2-canary.3152.34475910927.0
npm install @salutejs/sdds-bizcom@0.366.2-canary.3152.34475910927.0
npm install @salutejs/sdds-cs@0.370.2-canary.3152.34475910927.0
npm install @salutejs/sdds-dfa@0.364.2-canary.3152.34475910927.0
npm install @salutejs/sdds-finai@0.357.2-canary.3152.34475910927.0
npm install @salutejs/sdds-icons@0.6.1-canary.3152.34475910927.0
npm install @salutejs/sdds-insol@0.361.2-canary.3152.34475910927.0
npm install @salutejs/sdds-insol-next@0.360.2-canary.3152.34475910927.0
npm install @salutejs/sdds-netology@0.365.2-canary.3152.34475910927.0
npm install @salutejs/sdds-os@0.36.2-canary.3152.34475910927.0
npm install @salutejs/sdds-platform-ai@0.365.2-canary.3152.34475910927.0
npm install @salutejs/sdds-sbcom@0.366.2-canary.3152.34475910927.0
npm install @salutejs/sdds-scan@0.364.2-canary.3152.34475910927.0
npm install @salutejs/sdds-serv@0.365.2-canary.3152.34475910927.0
npm install @salutejs/core-themes@0.41.1-canary.3152.34475910927.0
npm install @salutejs/plasma-themes@0.63.1-canary.3152.34475910927.0
npm install @salutejs/sdds-themes@0.79.2-canary.3152.34475910927.0
npm install @salutejs/sdds-api-tests@0.23.2-canary.3152.34475910927.0
npm install @salutejs/plasma-cy-utils@0.171.2-canary.3152.34475910927.0
npm install @salutejs/plasma-sb-utils@0.242.2-canary.3152.34475910927.0
npm install @salutejs/plasma-tokens-utils@0.61.1-canary.3152.34475910927.0
# or 
yarn add @salutejs/plasma-asdk@0.392.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-b2c@1.634.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-colors@0.22.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-core@1.241.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-giga@0.361.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-homeds@0.361.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-hope@1.388.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-icons@1.249.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-new-hope@0.378.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens@1.152.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens-b2b@1.65.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens-b2c@0.76.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens-core@0.13.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens-web@1.80.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-typo@0.53.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-web@1.636.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-bizcom@0.366.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-cs@0.370.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-dfa@0.364.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-finai@0.357.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-icons@0.6.1-canary.3152.34475910927.0
yarn add @salutejs/sdds-insol@0.361.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-insol-next@0.360.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-netology@0.365.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-os@0.36.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-platform-ai@0.365.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-sbcom@0.366.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-scan@0.364.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-serv@0.365.2-canary.3152.34475910927.0
yarn add @salutejs/core-themes@0.41.1-canary.3152.34475910927.0
yarn add @salutejs/plasma-themes@0.63.1-canary.3152.34475910927.0
yarn add @salutejs/sdds-themes@0.79.2-canary.3152.34475910927.0
yarn add @salutejs/sdds-api-tests@0.23.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-cy-utils@0.171.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-sb-utils@0.242.2-canary.3152.34475910927.0
yarn add @salutejs/plasma-tokens-utils@0.61.1-canary.3152.34475910927.0

coderabbitai · 2026-09-08T13:13:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2f95f840-88da-4e03-95ae-3a4dd8043cd6

📥 Commits

Reviewing files that changed from the base of the PR and between d270c15 and 28e6065.

⛔ Files ignored due to path filters (12)

cypress/snapshots/giga/webkit/Dropdown/Dropdown -- behavior nesting lists within scroll.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop afterList.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop beforeList in items.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop beforeList.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop listWidth.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop nested dropdown placement.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop offset.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop placement, alwaysOpened.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop placement.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- prop variant, trigger.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- size=m.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Dropdown/Dropdown -- size=s.snap.png is excluded by !**/*.png

📒 Files selected for processing (1)

packages/plasma-giga/src/components/Dropdown/Dropdown.config.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The Dropdown configuration increases item border radii for the l, m, s, and xs size variations.

Changes

Dropdown styling

Layer / File(s)	Summary
Update size variation radii `packages/plasma-giga/src/components/Dropdown/Dropdown.config.ts`	The item border radius increases for the `l`, `m`, `s`, and `xs` variations.

Priority: ⬇️ Low — Defer the Dropdown styling update because it is a narrow visual change limited to item border radii across four size variations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 28e60

Dropdown items now use border radii aligned with their containers across all supported sizes. The change is limited to styling configuration and is ready to merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: aligning the Dropdown item border radius with the container. It is specific, concise, and related to the pull request objectives.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch PLASMA-8115.giga-dropdown-hover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-08T13:14:46Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3152/

github-actions · 2026-09-08T13:36:40Z

Documentation preview deployed!

vmytnik requested review from TitanKuzmich, Yakutoc, Yeti-or, neretin-trike and shuga2704 as code owners September 8, 2026 13:12

vmytnik temporarily deployed to internal September 8, 2026 13:12 — with GitHub Actions Inactive

vmytnik requested a review from luizasok September 9, 2026 07:43

Yakutoc removed request for Yakutoc, Yeti-or, neretin-trike and shuga2704 September 10, 2026 05:15

Yakutoc assigned vmytnik Sep 10, 2026

Yakutoc added the plasma-giga label Sep 10, 2026

TitanKuzmich approved these changes Sep 10, 2026

View reviewed changes

vmytnik force-pushed the PLASMA-8115.giga-dropdown-hover branch from 28e6065 to f591bc5 Compare September 10, 2026 07:15

vmytnik deployed to internal September 10, 2026 07:15 — with GitHub Actions Active

vmytnik force-pushed the PLASMA-8115.giga-dropdown-hover branch from f591bc5 to 714f83f Compare September 10, 2026 10:35

vmytnik deployed to internal September 10, 2026 10:35 — with GitHub Actions Active

fix(plasma-giga): Dropdown inner list border-radius [PLASMA-8115]

3c418e7

vmytnik force-pushed the PLASMA-8115.giga-dropdown-hover branch from 714f83f to 3c418e7 Compare September 10, 2026 12:17

vmytnik deployed to internal September 10, 2026 12:17 — with GitHub Actions Active

Navigation Menu

Uh oh!

PLASMA-8115: Dropdown item border-radius with container - #3152

PLASMA-8115: Dropdown item border-radius with container#3152
vmytnik wants to merge 1 commit into
devfrom
PLASMA-8115.giga-dropdown-hover

vmytnik commented Sep 8, 2026 •

edited by Salute-Eva

Loading

Uh oh!

coderabbitai Bot commented Sep 8, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vmytnik commented Sep 8, 2026 • edited by Salute-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PLASMA-GIGA

Dropdown

What/why changed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vmytnik commented Sep 8, 2026 •

edited by Salute-Eva

Loading

coderabbitai Bot commented Sep 8, 2026 •

edited

Loading

github-actions Bot commented Sep 8, 2026 •

edited

Loading