You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice to see this @iamEvanYT 🤝
We hit this exact bug migrating MASQ Browser (Electron 38) from an older fork (before the service-worker and MV3 support was merged into Electron) onto stock v4.9.0 — MV3 wallet extensions open their detached signing windows via chrome.windows.create with a relative URL (e.g. Rabby's notification.html), which reaches impl.createWindow unresolved and renders a blank window (ERR_ABORTED).
We independently arrived at the same fix (hoist validateExtensionUrl to common.ts, apply in WindowsAPI.create mirroring tabs.create) and have been running it in a stable staging build as a package patch: verified end-to-end with Rabby 0.93.82 and MetaMask (MV2 11.16.5 + MV3 13.38) signing flows.
+1 for merging — happy to help test!
(We're a Patron-licensed user. One adjacent gap we'll file separately: createWindowDetails hardcodes type: 'normal', which breaks many MV3 extensions with self-closing windows — it guards on windows.getCurrent().type === 'popup'.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves relative URLs so apps can open the correct URLs.
Also aligns behavior with
packages/electron-chrome-extensions/src/browser/api/tabs.tsBefore, createWindow implementation receives:
{ incognito: false, url: 'session-buddy.html' }After, createWindow implementation receives:
{ incognito: false, url: 'chrome-extension://edacconmaakjimmfgnblocblbcdcpbko/session-buddy.html' }✅ By sending this pull request, I agree to the Contributor License Agreement of this project.