Implement direct owned JSON records - #852
Merged
Merged
Conversation
Route both owned JSON encoders through the stack-safe MIR dispatch, cover nested owned templates, and add a structural deep-expression tripwire. Refresh the standalone library-boundary benchmark consumers and lockfile, and close the candidate Clippy warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string,Option<string>, andarray<string>fields with free-standing decode ownership, canonical encode, bounded encode, recursive Drop, and recoverable failure cleanupReview finding closure
JsonOwnedEncodeandJsonOwnedEncodeBoundedthrough MIR's stack-safe out-of-line dispatcher and recognize nested owned template spines; a structural deep-expression tripwire now pins the complete sibling setIFnSigandInterfaceSummaryrecords and refresh its independent lockfileVerification
scripts/cargo.sh test -p align_mir owned_json_encoders_use_stack_safe_dispatchscripts/cargo.sh check --manifest-path bench/library_boundary/Cargo.tomlscripts/cargo.sh test -p align_driver --test m5_owned_jsonCARGO_TARGET_DIR=target/clippy scripts/cargo.sh clippy --workspace --lib --binsscripts/lint-ratchet.shscripts/pre-pr.shwith the Request 9 end-to-end owner target, bounded gate, and locked workspace Clippy