Skip to content

fix(mir): preserve shared canonical graph traversal - #855

Merged
sanohiro merged 2 commits into
mainfrom
agent/fix-canonical-shared-inline-dag
Aug 18, 2026
Merged

fix(mir): preserve shared canonical graph traversal#855
sanohiro merged 2 commits into
mainfrom
agent/fix-canonical-shared-inline-dag

Conversation

@sanohiro

Copy link
Copy Markdown
Owner

Summary

  • Fix iterative canonical-graph traversal so shared inline DAGs are not classified as cycles.
  • Keep genuine self-cycles and mutual inline cycles rejected.
  • Add a regression test whose sibling scheduling order reproduces the old false-cycle result.

Verification

  • scripts/cargo.sh test -p align_mir canonical_graph
  • scripts/lint-ratchet.sh
  • scripts/test-pr.sh
  • scripts/cargo.sh clippy --workspace --lib --bins --locked -- -D warnings

The focused test, bounded gate, lint ratchet, and Clippy all pass. The preflight review found one P2 test-topology issue; the test was corrected in the single findings-fixed commit.

@sanohiro
sanohiro marked this pull request as ready for review August 18, 2026 05:44
@sanohiro
sanohiro merged commit a440970 into main Aug 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant