Convert frontend to React Router and improve app reliability#65
Open
santosderek wants to merge 8 commits into
Open
Convert frontend to React Router and improve app reliability#65santosderek wants to merge 8 commits into
santosderek wants to merge 8 commits into
Conversation
Owner
Author
|
Added the React Router conversion on top of the maintainability changes. React Router update
Additional validation
Docker build is still blocked locally because the Docker daemon is unavailable. |
Owner
Author
|
Removed the legacy Jinja/static frontend now that React Router owns the browser UI. Cleanup
Validation
|
Owner
Author
|
Follow-up split per feedback: Flask is now API/download only; the website UI is served by npm/Vite React Router. What changed
Local dev now
Validation
|
Owner
Author
|
Added the first visual modernization pass. Visual pass 1
Validation
|
Owner
Author
|
Added the full interactive TUI pass. Interaction pass
ASCII direction implementedValidation
|
Owner
Author
|
Refined the TUI window based on feedback. Changes
Playwright checks
Note: Playwright screenshot capture timed out waiting on the browser screenshot operation, but navigation/text/evaluate checks passed. Validation
|
Owner
Author
|
Removed the top nav bar shown in the screenshot and applied the TUI font styling to the left module nav. Changes
Validation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_document(location=...), and keep/resumeas the Python download endpointfrontend//, project pages, robots, sitemap, and static assets; Flask now owns only/api/v1/*and/resume/api/v1/github/userso the React home page can keep the dynamic GitHub repo-count behavior through the backend connector fallbackrequirements.in+ exactrequirements.txt; add pinned frontendpackage-lock.jsonLocal dev
http://127.0.0.1:8000(/api/v1/*,/resume)http://127.0.0.1:5173Validation
npm ci --prefix frontend✅npm test --prefix frontend -- --run✅ 4 passednpm run build --prefix frontend✅.venv/bin/python -m pytest -q✅ 30 passeduv run --python 3.10 --with-requirements requirements.txt python -m pytest -q✅ 30 passeduv pip check --python ./.venv/bin/python✅ no broken requirementssh -n docker-entrypoint.sh✅git diff --check✅http://127.0.0.1:5173/✅Notes
Cannot connect to the Docker daemon at unix:///Users/dersanto/.docker/run/docker.sock).workflowscope.