Skip to content

Convert to TypeScript, rework support for React 18, Refresh latest logic from JotForm#6

Open
mg-aceik wants to merge 1 commit into
sbayd:mainfrom
mg-aceik:main
Open

Convert to TypeScript, rework support for React 18, Refresh latest logic from JotForm#6
mg-aceik wants to merge 1 commit into
sbayd:mainfrom
mg-aceik:main

Conversation

@mg-aceik

@mg-aceik mg-aceik commented Oct 11, 2023

Copy link
Copy Markdown

I don't use pnpm so haven't checked in the lock file.
I also haven't checked the storybook, I was testing on a separate project.
Fixed #5.

@awc120

awc120 commented Oct 18, 2023

Copy link
Copy Markdown

@sbayd @mg-aceik Hey on both the main branch, as well as this PR we are getting a linting error when using this module:

Type error: Could not find a declaration file for module 'jotform-react'. '/app/node_modules/jotform-react/dist/index.cjs.js' implicitly has an 'any' type.
Try npm i --save-dev @types/jotform-react if it exists or add a new declaration (.d.ts) file containing declare module 'jotform-react';

Wanted to flag this, thanks!

@mg-aceik

Copy link
Copy Markdown
Author

@awc120 this PR isn't published to NPM yet so that issue isn't from this. To use this PR just copy the https://github.com/mg-aceik/jotform-react/blob/main/lib/index.tsx into your solution.

@mattclosson

Copy link
Copy Markdown

can we publish this?

@CrutchTheClutch CrutchTheClutch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the lockfile is deleted? It should be regenerated and added to this pr. Otherwise, I think it looks good!

(edit) just realized your initial comment mentioned this. Should still get corrected prior to merge. I am not sure if this is maintained anymore though

@dawb

dawb commented Jan 15, 2024

Copy link
Copy Markdown

@mg-aceik would it be possible to generate so we can release this update?

@dsoraluz

dsoraluz commented Feb 5, 2024

Copy link
Copy Markdown

@mg-aceik can we get this published?

@mg-aceik

mg-aceik commented Feb 5, 2024

Copy link
Copy Markdown
Author

Someone else will need to take over the requested changes here, I'm not using Jotform anymore - switched to Paperform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update react peer dependency version

6 participants