fmt: add --ir to print the pretty printing IR - #1314
Closed
sbdchd wants to merge 1 commit into
Closed
Conversation
When a statement formats in a surprising way it helps to see the
`tiny_pretty::Doc` tree the formatter built, rather than the text that
tree printed to, so `squawk-fmt --ir` (and `squawk_fmt::fmt_ir`) dumps
it:
$ echo 'select a from t;' | squawk-fmt --ir
list [
group [
group [
text "select"
nest 2 [ line_or_space list [ text "a" ] ]
]
line_or_space
text "from"
space
nest 2 [ list [ text "t" ] ]
text ";"
]
]
`Doc` derives `Debug`, but `{:#?}` is ~6x more lines and `Doc::Nest`'s
payload type isn't exported by tiny_pretty, so we can't walk the tree
ourselves. Instead we parse the `Debug` output, which is a small,
regular grammar, and re-render it compactly, falling back to the raw
`{:#?}` if that parse ever fails.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dhw2RENug3ippmngYuaHop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a statement formats in a surprising way it helps to see the
tiny_pretty::Doctree the formatter built, rather than the text thattree printed to, so
squawk-fmt --ir(andsquawk_fmt::fmt_ir) dumpsit:
DocderivesDebug, but{:#?}is ~6x more lines andDoc::Nest'spayload type isn't exported by tiny_pretty, so we can't walk the tree
ourselves. Instead we parse the
Debugoutput, which is a small,regular grammar, and re-render it compactly, falling back to the raw
{:#?}if that parse ever fails.Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Dhw2RENug3ippmngYuaHop