Skip to content

parser: add validation for function defaults #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Sep 1, 2026
Merged

parser: add validation for function defaults #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 109 additions & 88 deletions ...s/squawk_syntax/src/snapshots/squawk_syntax__test__alter_aggregate_params_validation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,103 +2,124 @@
source: crates/squawk_syntax/src/test.rs
input_file: crates/squawk_syntax/test_data/validation/alter_aggregate_params.sql
---
SOURCE_FILE@0..120
SOURCE_FILE@0..166
COMMENT@0..38 "-- can't have out par ..."
WHITESPACE@38..39 "\n"
CREATE_AGGREGATE@39..119
CREATE_KW@39..45 "create"
WHITESPACE@45..46 " "
AGGREGATE_KW@46..55 "aggregate"
WHITESPACE@55..56 " "
AGGREGATE_NAME@56..57
PATH@56..57
PATH_SEGMENT@56..57
IDENT@56..57 "a"
PARAM_LIST@57..89
L_PAREN@57..58 "("
PARAM@58..62
PARAM_IN@58..60
IN_KW@58..60 "in"
WHITESPACE@60..61 " "
PATH_TYPE@61..62
PATH_REF@61..62
PATH_SEGMENT_REF@61..62
IDENT@61..62 "x"
COMMA@62..63 ","
WHITESPACE@63..64 " "
PARAM@64..69
PARAM_OUT@64..67
OUT_KW@64..67 "out"
WHITESPACE@67..68 " "
PATH_TYPE@68..69
PATH_REF@68..69
PATH_SEGMENT_REF@68..69
IDENT@68..69 "y"
COMMA@69..70 ","
WHITESPACE@70..71 " "
PARAM@71..78
PARAM_IN_OUT@71..76
INOUT_KW@71..76 "inout"
WHITESPACE@76..77 " "
PATH_TYPE@77..78
PATH_REF@77..78
PATH_SEGMENT_REF@77..78
IDENT@77..78 "z"
COMMA@78..79 ","
WHITESPACE@79..80 " "
PARAM@80..88
PARAM_IN_OUT@80..86
IN_KW@80..82 "in"
WHITESPACE@82..83 " "
OUT_KW@83..86 "out"
WHITESPACE@86..87 " "
PATH_TYPE@87..88
PATH_REF@87..88
PATH_SEGMENT_REF@87..88
IDENT@87..88 "w"
R_PAREN@88..89 ")"
WHITESPACE@89..90 " "
ATTRIBUTE_LIST@90..118
L_PAREN@90..91 "("
WHITESPACE@91..94 "\n "
ATTRIBUTE_OPTION@94..103
ATTRIBUTE_NAME@94..99
IDENT@94..99 "sfunc"
WHITESPACE@99..100 " "
EQ@100..101 "="
WHITESPACE@101..102 " "
ATTRIBUTE_VALUE@102..103
PATH_TYPE@102..103
PATH_REF@102..103
PATH_SEGMENT_REF@102..103
IDENT@102..103 "f"
COMMA@103..104 ","
WHITESPACE@104..107 "\n "
ATTRIBUTE_OPTION@107..116
ATTRIBUTE_NAME@107..112
IDENT@107..112 "stype"
WHITESPACE@112..113 " "
EQ@113..114 "="
WHITESPACE@114..115 " "
ATTRIBUTE_VALUE@115..116
PATH_TYPE@115..116
PATH_REF@115..116
PATH_SEGMENT_REF@115..116
IDENT@115..116 "t"
WHITESPACE@116..117 "\n"
R_PAREN@117..118 ")"
SEMICOLON@118..119 ";"
WHITESPACE@119..120 "\n"
ALTER_AGGREGATE@39..107
ALTER_KW@39..44 "alter"
WHITESPACE@44..45 " "
AGGREGATE_KW@45..54 "aggregate"
WHITESPACE@54..55 " "
AGGREGATE@55..89
PATH_REF@55..56
PATH_SEGMENT_REF@55..56
IDENT@55..56 "a"
WHITESPACE@56..57 " "
PARAM_LIST@57..89
L_PAREN@57..58 "("
PARAM@58..62
PARAM_IN@58..60
IN_KW@58..60 "in"
WHITESPACE@60..61 " "
PATH_TYPE@61..62
PATH_REF@61..62
PATH_SEGMENT_REF@61..62
IDENT@61..62 "t"
COMMA@62..63 ","
WHITESPACE@63..64 " "
PARAM@64..69
PARAM_OUT@64..67
OUT_KW@64..67 "out"
WHITESPACE@67..68 " "
PATH_TYPE@68..69
PATH_REF@68..69
PATH_SEGMENT_REF@68..69
IDENT@68..69 "u"
COMMA@69..70 ","
WHITESPACE@70..71 " "
PARAM@71..78
PARAM_IN_OUT@71..76
INOUT_KW@71..76 "inout"
WHITESPACE@76..77 " "
PATH_TYPE@77..78
PATH_REF@77..78
PATH_SEGMENT_REF@77..78
IDENT@77..78 "v"
COMMA@78..79 ","
WHITESPACE@79..80 " "
PARAM@80..88
PARAM_IN_OUT@80..86
IN_KW@80..82 "in"
WHITESPACE@82..83 " "
OUT_KW@83..86 "out"
WHITESPACE@86..87 " "
PATH_TYPE@87..88
PATH_REF@87..88
PATH_SEGMENT_REF@87..88
IDENT@87..88 "w"
R_PAREN@88..89 ")"
WHITESPACE@89..94 "\n "
SET_SCHEMA@94..106
SET_KW@94..97 "set"
WHITESPACE@97..98 " "
SCHEMA_KW@98..104 "schema"
WHITESPACE@104..105 " "
SCHEMA_REF@105..106
IDENT@105..106 "s"
SEMICOLON@106..107 ";"
WHITESPACE@107..109 "\n\n"
ALTER_AGGREGATE@109..165
ALTER_KW@109..114 "alter"
WHITESPACE@114..115 " "
AGGREGATE_KW@115..124 "aggregate"
WHITESPACE@124..125 " "
AGGREGATE@125..151
PATH_REF@125..126
PATH_SEGMENT_REF@125..126
IDENT@125..126 "a"
PARAM_LIST@126..151
L_PAREN@126..127 "("
PARAM@127..150
PARAM_NAME@127..132
VALUE_KW@127..132 "value"
WHITESPACE@132..133 " "
PATH_TYPE@133..140
PATH_REF@133..140
PATH_SEGMENT_REF@133..140
INTEGER_KW@133..140 "integer"
WHITESPACE@140..141 " "
PARAM_DEFAULT@141..150
DEFAULT_KW@141..148 "default"
WHITESPACE@148..149 " "
LITERAL@149..150
INT_NUMBER@149..150 "1"
R_PAREN@150..151 ")"
WHITESPACE@151..152 " "
AGGREGATE_RENAME_TO@152..164
RENAME_KW@152..158 "rename"
WHITESPACE@158..159 " "
TO_KW@159..161 "to"
WHITESPACE@161..162 " "
AGGREGATE_NAME@162..164
PATH@162..164
PATH_SEGMENT@162..164
IDENT@162..164 "a2"
SEMICOLON@164..165 ";"
WHITESPACE@165..166 "\n"

error[syntax-error]: Out params are not allowed with aggregates.
╭▸
2 │ create aggregate a(in x, out y, inout z, in out w) (
2 │ alter aggregate a (in t, out u, inout v, in out w)
╰╴ ━━━
error[syntax-error]: In Out params are not allowed with aggregates.
╭▸
2 │ create aggregate a(in x, out y, inout z, in out w) (
2 │ alter aggregate a (in t, out u, inout v, in out w)
╰╴ ━━━━━
error[syntax-error]: In Out params are not allowed with aggregates.
╭▸
2 │ create aggregate a(in x, out y, inout z, in out w) (
2 │ alter aggregate a (in t, out u, inout v, in out w)
╰╴ ━━━━━━
error[syntax-error]: Defaults are not allowed.
╭▸
5 │ alter aggregate a(value integer default 1) rename to a2;
╰╴ ━━━━━━━━━
49 changes: 49 additions & 0 deletions crates/squawk_syntax/src/snapshots/squawk_syntax__test__alter_function_validation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
---
source: crates/squawk_syntax/src/test.rs
input_file: crates/squawk_syntax/test_data/validation/alter_function.sql
---
SOURCE_FILE@0..56
ALTER_FUNCTION@0..55
ALTER_KW@0..5 "alter"
WHITESPACE@5..6 " "
FUNCTION_KW@6..14 "function"
WHITESPACE@14..15 " "
FUNCTION_SIG@15..41
FUNCTION_NAME_REF@15..16
PATH_REF@15..16
PATH_SEGMENT_REF@15..16
IDENT@15..16 "f"
PARAM_LIST@16..41
L_PAREN@16..17 "("
PARAM@17..40
PARAM_NAME@17..22
VALUE_KW@17..22 "value"
WHITESPACE@22..23 " "
PATH_TYPE@23..30
PATH_REF@23..30
PATH_SEGMENT_REF@23..30
INTEGER_KW@23..30 "integer"
WHITESPACE@30..31 " "
PARAM_DEFAULT@31..40
DEFAULT_KW@31..38 "default"
WHITESPACE@38..39 " "
LITERAL@39..40
INT_NUMBER@39..40 "1"
R_PAREN@40..41 ")"
WHITESPACE@41..42 " "
FUNCTION_RENAME_TO@42..54
RENAME_KW@42..48 "rename"
WHITESPACE@48..49 " "
TO_KW@49..51 "to"
WHITESPACE@51..52 " "
FUNCTION_NAME@52..54
PATH@52..54
PATH_SEGMENT@52..54
IDENT@52..54 "f2"
SEMICOLON@54..55 ";"
WHITESPACE@55..56 "\n"

error[syntax-error]: Defaults are not allowed.
╭▸
1 │ alter function f(value integer default 1) rename to f2;
╰╴ ━━━━━━━━━
49 changes: 49 additions & 0 deletions crates/squawk_syntax/src/snapshots/squawk_syntax__test__alter_procedure_validation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
---
source: crates/squawk_syntax/src/test.rs
input_file: crates/squawk_syntax/test_data/validation/alter_procedure.sql
---
SOURCE_FILE@0..57
ALTER_PROCEDURE@0..56
ALTER_KW@0..5 "alter"
WHITESPACE@5..6 " "
PROCEDURE_KW@6..15 "procedure"
WHITESPACE@15..16 " "
PROCEDURE_SIG@16..42
PROCEDURE_NAME_REF@16..17
PATH_REF@16..17
PATH_SEGMENT_REF@16..17
IDENT@16..17 "p"
PARAM_LIST@17..42
L_PAREN@17..18 "("
PARAM@18..41
PARAM_NAME@18..23
VALUE_KW@18..23 "value"
WHITESPACE@23..24 " "
PATH_TYPE@24..31
PATH_REF@24..31
PATH_SEGMENT_REF@24..31
INTEGER_KW@24..31 "integer"
WHITESPACE@31..32 " "
PARAM_DEFAULT@32..41
DEFAULT_KW@32..39 "default"
WHITESPACE@39..40 " "
LITERAL@40..41
INT_NUMBER@40..41 "1"
R_PAREN@41..42 ")"
WHITESPACE@42..43 " "
PROCEDURE_RENAME_TO@43..55
RENAME_KW@43..49 "rename"
WHITESPACE@49..50 " "
TO_KW@50..52 "to"
WHITESPACE@52..53 " "
PROCEDURE_NAME@53..55
PATH@53..55
PATH_SEGMENT@53..55
IDENT@53..55 "p2"
SEMICOLON@55..56 ";"
WHITESPACE@56..57 "\n"

error[syntax-error]: Defaults are not allowed.
╭▸
1 │ alter procedure p(value integer default 1) rename to p2;
╰╴ ━━━━━━━━━
49 changes: 49 additions & 0 deletions crates/squawk_syntax/src/snapshots/squawk_syntax__test__alter_routine_validation.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
---
source: crates/squawk_syntax/src/test.rs
input_file: crates/squawk_syntax/test_data/validation/alter_routine.sql
---
SOURCE_FILE@0..55
ALTER_ROUTINE@0..54
ALTER_KW@0..5 "alter"
WHITESPACE@5..6 " "
ROUTINE_KW@6..13 "routine"
WHITESPACE@13..14 " "
ROUTINE_SIG@14..40
ROUTINE_NAME_REF@14..15
PATH_REF@14..15
PATH_SEGMENT_REF@14..15
IDENT@14..15 "r"
PARAM_LIST@15..40
L_PAREN@15..16 "("
PARAM@16..39
PARAM_NAME@16..21
VALUE_KW@16..21 "value"
WHITESPACE@21..22 " "
PATH_TYPE@22..29
PATH_REF@22..29
PATH_SEGMENT_REF@22..29
INTEGER_KW@22..29 "integer"
WHITESPACE@29..30 " "
PARAM_DEFAULT@30..39
DEFAULT_KW@30..37 "default"
WHITESPACE@37..38 " "
LITERAL@38..39
INT_NUMBER@38..39 "1"
R_PAREN@39..40 ")"
WHITESPACE@40..41 " "
ROUTINE_RENAME_TO@41..53
RENAME_KW@41..47 "rename"
WHITESPACE@47..48 " "
TO_KW@48..50 "to"
WHITESPACE@50..51 " "
ROUTINE_NAME@51..53
PATH@51..53
PATH_SEGMENT@51..53
IDENT@51..53 "r2"
SEMICOLON@53..54 ";"
WHITESPACE@54..55 "\n"

error[syntax-error]: Defaults are not allowed.
╭▸
1 │ alter routine r(value integer default 1) rename to r2;
╰╴ ━━━━━━━━━
Loading
Loading