impr(ARSN-608): Add support for passing targetAccount to Vault in request context by tmacro · Pull Request #2670 · scality/Arsenal

tmacro · 2026-07-07T16:14:47Z

No description provided.

bert-e · 2026-07-07T16:14:51Z

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-07-07T16:16:08Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

tmacro · 2026-07-07T16:16:55Z

/create_integration_branches

bert-e · 2026-07-07T16:17:04Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context with contents from improvement/ARSN-608/support_targetAccount_in_req_context
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context origin/development/8.5
 git merge origin/improvement/ARSN-608/support_targetAccount_in_req_context
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context

The following options are set: create_integration_branches

codecov · 2026-07-07T16:22:50Z

Codecov Report

❌ Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.40%. Comparing base (015857e) to head (33b8076).
⚠️ Report is 2 commits behind head on development/8.4.

Files with missing lines	Patch %	Lines
lib/auth/Vault.ts	92.10%	3 Missing ⚠️
lib/auth/auth.ts	93.75%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.4    #2670      +/-   ##
===================================================
- Coverage            74.41%   74.40%   -0.01%     
===================================================
  Files                  229      229              
  Lines                18539    18533       -6     
  Branches              3817     3814       -3     
===================================================
- Hits                 13795    13790       -5     
+ Misses                4739     4738       -1     
  Partials                 5        5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tmacro · 2026-07-07T17:24:28Z

/reset

bert-e · 2026-07-07T17:24:37Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2026-07-07T17:26:45Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tcarmet

LGTM but I think the commits deserves a re-work between what's formatting and what new additional change I got a bit confused when reviewing

tcarmet · 2026-07-07T21:44:34Z

        "node": ">=20"
    },
-    "version": "8.4.18",
+    "version": "8.4.19",


Depending on where this is supposed to land, I would redirect you to use the 8.5 version of arsenal since this is an addition (a small and harmless addition but addition nonetheless)

But ultimately it's your call cause it might cause you some trouble (for example if you're aiming cloudserver 9.3, but on 9.4 you will be fine).

anurag4DSB

There are a lot of formatting changes, was hard to find the actual change(which is small). Would be nice to have the lint changes in a separate commit next time :)

tmacro · 2026-07-08T14:42:36Z

@anurag4DSB

There are a lot of formatting changes, was hard to find the actual change(which is small). Would be nice to have the lint changes in a separate commit next time :)

I'll split them out. I didn't realize prettier had made that many changes.

…uest context

bert-e · 2026-07-08T15:06:24Z

History mismatch

Merge commit #c458a72f96613a0546e72cb83b19013c818e1c3d on the integration branch
w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context is merging a branch which is neither the current
branch improvement/ARSN-608/support_targetAccount_in_req_context nor the development branch
development/8.5.

It is likely due to a rebase of the branch improvement/ARSN-608/support_targetAccount_in_req_context and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

tmacro · 2026-07-08T15:06:25Z

/reset

bert-e · 2026-07-08T15:06:33Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2026-07-08T15:06:40Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context with contents from improvement/ARSN-608/support_targetAccount_in_req_context
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context origin/development/8.5
 git merge origin/improvement/ARSN-608/support_targetAccount_in_req_context
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.5/improvement/ARSN-608/support_targetAccount_in_req_context

The following options are set: create_integration_branches

claude · 2026-07-08T15:08:07Z

-            const result = info.message.body;
-            return callback(null, result);
-        });
+        log.trace('sending request context params to vault to evaluate' + 'policies');


Missing space between "evaluate" and "policies" — the concatenation produces "...to evaluatepolicies".

Suggested change

log.trace('sending request context params to vault to evaluate' + 'policies');

log.trace('sending request context params to vault to evaluate policies');

tmacro · 2026-07-08T15:17:41Z

/reset

bert-e · 2026-07-08T15:17:44Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2026-07-08T15:53:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

tmacro · 2026-07-08T22:45:02Z

/approve

bert-e · 2026-07-08T22:45:19Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/8.4
✔️ development/8.5

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1
development/8.2
development/8.3

This pull request does not target the following hotfix branch(es) so they
will be left untouched:

hotfix/7.10.29
hotfix/7.2.0
hotfix/7.10.31
hotfix/6.4.7
hotfix/7.10.0
hotfix/7.4.3
hotfix/7.4.6
hotfix/7.8.0
hotfix/7.5.0
hotfix/7.70.14
hotfix/7.10.46
hotfix/7.10.47
hotfix/7.9.0
hotfix/7.10.1
hotfix/7.4.8
hotfix/7.10.4
hotfix/7.4.7
hotfix/7.10.43
hotfix/7.10.3
hotfix/7.4.9
hotfix/7.4.10
hotfix/7.4.0
hotfix/7.10.36
hotfix/7.10.57
hotfix/7.4.1
hotfix/7.10.2
hotfix/7.7.0
hotfix/7.70.25
hotfix/8.2.48
hotfix/7.70.20
hotfix/7.70.4
hotfix/7.4.4
hotfix/7.4.5
hotfix/7.4.2
hotfix/7.6.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2026-07-08T22:53:51Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.4
✔️ development/8.5

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1
development/8.2
development/8.3

Please check the status of the associated issue ARSN-608.

Goodbye tmacro.

scality deleted a comment from bert-e Jul 7, 2026

tmacro force-pushed the improvement/ARSN-608/support_targetAccount_in_req_context branch from f8bb82a to 6332622 Compare July 7, 2026 17:24

scality deleted a comment from bert-e Jul 7, 2026

scality deleted a comment from claude Bot Jul 7, 2026

tcarmet approved these changes Jul 7, 2026

View reviewed changes

anurag4DSB approved these changes Jul 8, 2026

View reviewed changes

impr(ARSN-608): Add support for passing targetAccount to Vault in req…

981036d

…uest context

tmacro force-pushed the improvement/ARSN-608/support_targetAccount_in_req_context branch from 701c2e2 to e0948a6 Compare July 8, 2026 15:06

claude Bot reviewed Jul 8, 2026

View reviewed changes

tmacro added 2 commits July 8, 2026 08:17

Format using prettier

1fab61a

Bump project version

33b8076

tmacro force-pushed the improvement/ARSN-608/support_targetAccount_in_req_context branch from e0948a6 to 33b8076 Compare July 8, 2026 15:17

scality deleted a comment from bert-e Jul 8, 2026

bert-e merged commit 059ecf4 into development/8.4 Jul 8, 2026
14 checks passed

bert-e deleted the improvement/ARSN-608/support_targetAccount_in_req_context branch July 8, 2026 22:53

	log.trace('sending request context params to vault to evaluate' + 'policies');
	log.trace('sending request context params to vault to evaluate policies');

Uh oh!

Conversation

tmacro commented Jul 7, 2026

Uh oh!

bert-e commented Jul 7, 2026

Hello tmacro,

Uh oh!

bert-e commented Jul 7, 2026

Request integration branches

Uh oh!

tmacro commented Jul 7, 2026

Uh oh!

bert-e commented Jul 7, 2026

Conflict

Uh oh!

codecov Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tmacro commented Jul 7, 2026

Uh oh!

bert-e commented Jul 7, 2026

Reset complete

Uh oh!

bert-e commented Jul 7, 2026

Waiting for approval

Uh oh!

tcarmet left a comment

Choose a reason for hiding this comment

Uh oh!

tcarmet Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

anurag4DSB left a comment

Choose a reason for hiding this comment

Uh oh!

tmacro commented Jul 8, 2026

Uh oh!

bert-e commented Jul 8, 2026

History mismatch

Uh oh!

tmacro commented Jul 8, 2026

Uh oh!

bert-e commented Jul 8, 2026

Reset complete

Uh oh!

bert-e commented Jul 8, 2026

Conflict

Uh oh!

claude Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

tmacro commented Jul 8, 2026

Uh oh!

bert-e commented Jul 8, 2026

Reset complete

Uh oh!

bert-e commented Jul 8, 2026

Waiting for approval

Uh oh!

tmacro commented Jul 8, 2026

Uh oh!

bert-e commented Jul 8, 2026

In the queue

Uh oh!

bert-e commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jul 7, 2026 •

edited

Loading