utils: support IEC binary size units (KiB..PiB)#47
Merged
Conversation
storcli2 reports sizes with IEC labels (e.g. "9.094 TiB") that ConvertSizeBytes rejected. Map KiB/MiB/GiB/TiB/PiB to the same binary multipliers as the existing KB..PB labels. These RAID CLIs report binary quantities regardless of label (ssacli "800 GB" == 858993459200 == 800 GiB; megaraid "16.370 TB" == 17999005346693 == 16.370 TiB), so both families share the 1024-based multiplier; a comment and tests document this on purpose.
TeddyAndrieux
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storcli2 reports sizes with IEC labels (e.g. "9.094 TiB") that ConvertSizeBytes
rejected. Map KiB/MiB/GiB/TiB/PiB to the same binary multipliers as the existing
KB..PB labels. These RAID CLIs report binary quantities regardless of label
(ssacli "800 GB" == 858993459200 == 800 GiB; megaraid "16.370 TB" ==
17999005346693 == 16.370 TiB), so both families share the 1024-based multiplier;
a comment and tests document this on purpose.