Skip to content

Run proto-review on pull_request_target so forks get a write token #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jupblb merged 2 commits into from
Jun 17, 2026
Merged

Run proto-review on pull_request_target so forks get a write token #443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4335371
proto-review: run on pull_request_target so forks get a write token
jupblb Jun 17, 2026
55b14e3
Fix wording
jupblb Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/proto-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: SCIP protocol review

on:
pull_request:
pull_request_target:
paths: [scip.proto]
pull_request_review:

Expand All @@ -11,6 +11,12 @@ permissions:

jobs:
proto-review:
# `pull_request_review` is read-only on forks; otherwise the workflow would
# use a GitHub token without the necessary permissions. Restart the failed
# workflow once all approvals are gathered.
if: >-
github.event_name == 'pull_request_target' ||
github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
steps:
- uses: Automattic/action-required-review@v5
Expand Down