Skip to content

[essimaging] Odin image normalization wf#664

Merged
nvaytet merged 13 commits into
mainfrom
odin-image-normalization-wf
Jul 9, 2026
Merged

[essimaging] Odin image normalization wf#664
nvaytet merged 13 commits into
mainfrom
odin-image-normalization-wf

Conversation

@nvaytet

@nvaytet nvaytet commented Jul 2, 2026

Copy link
Copy Markdown
Member

We add the analog to the TBL Orca image normalization for Odin.

Odin will not have 3 separate files for dark, open beam and sample runs, all will be recorded in one file.
The data is split according to ImageKey (as was for Ymir).

We are able to re-use the orca workflow from TBL (that was moved into the common imaging folder) and insert providers that spit the data. We use a new RunType AllRuns to load a single file first, and then use a trick to re-use the FluxNormalizedDetector to transform AllRuns into SampleRun, OpenBeamRun, and DarkBackgroundRun`.

The visualization graph looks a little weird but the workflow works fine:
Screenshot_20260702_221825

Note that this is a little different from the Ymir implementation.

Edit:

I had to change the workflow graph because now we subtract the Dark background before we normalize by proton charge. So instead we use image key at the CorrectedDetector step, and we use the full ProtonCharge[AllRuns] log when normalizing by proton charge. It doesn't really hurt to search inside a slightly longer log, and this was simpler than also extracting the correct part of the log for each file (as we would have to make sure we get all the relevant data, also in the future taking into account travel time down the beam path).

The graph now looks like
Screenshot_20260709_155946

@nvaytet nvaytet requested a review from YooSunYoung July 2, 2026 20:21
@nvaytet nvaytet added the essimaging Issues for essimaging. label Jul 2, 2026
@nvaytet nvaytet changed the base branch from main to orca-normalization-fix July 2, 2026 20:22
@YooSunYoung YooSunYoung self-assigned this Jul 7, 2026

@YooSunYoung YooSunYoung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...!

We probably have to support merging multiple files too.
e.g. Users Acquired SampleRun, OpenBeam over night and then later decided to collect more OpenBeam in another file.
But I don't have a good idea now...

Base automatically changed from orca-normalization-fix to main July 9, 2026 13:39

@YooSunYoung YooSunYoung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good...!

@nvaytet nvaytet added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit 7a2144f Jul 9, 2026
6 checks passed
@nvaytet nvaytet deleted the odin-image-normalization-wf branch July 9, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

essimaging Issues for essimaging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants