[essimaging] Odin image normalization wf#664
Merged
Merged
Conversation
YooSunYoung
approved these changes
Jul 7, 2026
YooSunYoung
left a comment
Member
There was a problem hiding this comment.
LGTM...!
We probably have to support merging multiple files too.
e.g. Users Acquired SampleRun, OpenBeam over night and then later decided to collect more OpenBeam in another file.
But I don't have a good idea now...
…d the DarkFrame before we normalize by proton charge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add the analog to the TBL Orca image normalization for Odin.
Odin will not have 3 separate files for dark, open beam and sample runs, all will be recorded in one file.
The data is split according to
ImageKey(as was for Ymir).We are able to re-use the orca workflow from TBL (that was moved into the common
imagingfolder) and insert providers that spit the data. We use a new RunTypeAllRunsto load a single file first, and then use a trick to re-use theFluxNormalizedDetectorto transformAllRunsintoSampleRun,OpenBeamRun, andDarkBackgroundRun`.The visualization graph looks a little weird but the workflow works fine:

Note that this is a little different from the Ymir implementation.
Edit:
I had to change the workflow graph because now we subtract the Dark background before we normalize by proton charge. So instead we use image key at the
CorrectedDetectorstep, and we use the fullProtonCharge[AllRuns]log when normalizing by proton charge. It doesn't really hurt to search inside a slightly longer log, and this was simpler than also extracting the correct part of the log for each file (as we would have to make sure we get all the relevant data, also in the future taking into account travel time down the beam path).The graph now looks like
