Skip to content

Dockerize tests#62

Open
ryansanford wants to merge 10 commits into
masterfrom
dockerize-tests
Open

Dockerize tests#62
ryansanford wants to merge 10 commits into
masterfrom
dockerize-tests

Conversation

@ryansanford

@ryansanford ryansanford commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

Here's the skeleton for dockerized tests for review tomorrow.

Things I'm explicitly seeking buy-in on. not married to existing implementation, but wanted to do something for sake of discussion:

  • TEST_ARGS pass-through options for docker/test.sh to test/bin/test.sh
  • Cache orthanc docker image. (45s on travis with no caching)
  • level of input validation appropriate. I'd prefer more extensive
  • location of docker/test.sh. This still feels awkward to me. If I'm new to a repo, I expect to find test convience scripts in test/bin. Maybe this is wrong and I need to get over this?
  • WIP...

@ryansanford

Copy link
Copy Markdown
Contributor Author

@gsfr Heads up

@gsfr

gsfr commented Jun 9, 2017

Copy link
Copy Markdown
Member

@ryansanford Per offline discussion, please minimize orthanc-config.json and rename test directory to tests to avoid bash keyword conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants