chore: use memory store in tests - #2634
Open
ilan-gold wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
==========================================
- Coverage 87.66% 85.83% -1.83%
==========================================
Files 49 49
Lines 8121 8133 +12
==========================================
- Hits 7119 6981 -138
- Misses 1002 1152 +150
|
Contributor
Author
|
Not too shabby! https://github.com/scverse/anndata/actions/runs/33877901352/job/101039244161 for example took 13min but now it runs in 9min! |
ilan-gold
marked this pull request as ready for review
September 4, 2026 15:42
Removed the synchronous get_sync method from the helper class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to resolve the problem "what if our zarr tests didn't take so long and we also didn't write SO much data during testing" by moving to memory stores where possible - there is still a test explicitly for local storage in
tests/test_readwrite.py::test_readwrite_equivalent_h5ad_zarr(or where appropriate to not change) but otherwise, this should provide a big speedup!