feat: add configurable columns to PAGA plots - #4325
Open
AtomicGlance wants to merge 2 commits into
Open
Conversation
Signed-off-by: AtomicGlance <amiralimoradniaei@gmail.com>
Author
|
The code and focused tests are in place. One repository metadata check is failing only because this fork PR cannot add the required no milestone label without upstream permissions. Could a maintainer add that label or assign a milestone? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
+ Coverage 80.14% 80.17% +0.02%
==========================================
Files 133 133
Lines 13478 13497 +19
==========================================
+ Hits 10802 10821 +19
Misses 2676 2676
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AtomicGlance <amiralimoradniaei@gmail.com>
Author
|
Thanks for flagging this. I added coverage for invalid ncols values, the ncols plus pre-supplied ax error, and a custom colorbar axis, then pushed b6c4457. The focused PAGA tests now pass 11 cases; Codecov should rerun on the new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1203
Tests