Add load-time configuration options to get_dsp()#281
Draft
sdatkinson wants to merge 2 commits into
Draft
Conversation
Owner
Author
|
Current version of this I'm afraid doesn't resolve the actual issue. Continuing to massage. |
Owner
Author
|
If #285 turns out nicely, then I may change this and implement it by putting the defaults in a context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269.
Adds optional get_dsp() parameters for caller-provided load-time configuration:
This lets callers load a model directly into the intended runtime state, avoiding extra post-load Reset() and SetSlimmableSize() calls. The default behavior is preserved when no options are provided.
Also updates slimmable model handling so initial slimmable selection can happen before reset/prewarm, and corrects the Reset() documentation to match current behavior.