[Graphite MQ] Draft PR GROUP:batch_0ee745 (PRs 609, 619)#626
Closed
graphite-app[bot] wants to merge 2 commits into
Closed
[Graphite MQ] Draft PR GROUP:batch_0ee745 (PRs 609, 619)#626graphite-app[bot] wants to merge 2 commits into
graphite-app[bot] wants to merge 2 commits into
Conversation
…ly symbols and test fixtures on macOS (SEA-634/SEA-714)` (#609) # Pull request ## Summary Silences macOS clippy and dead-code warnings that surfaced when Linux-only sandbox bridge symbols (`netbridge_in_sandbox_path`, `XDG_DBUS_PROXY_BINARY`, `resolve_xdg_dbus_proxy_binary`, D-Bus address resolution helpers, `ProxyHandle::new`, `DbusProxyHandle::new`, `spawn_dbus_proxy`) are compiled on macOS without a corresponding call site. Also suppresses `clippy::disallowed_methods` in test fixtures where `std::env::var`, `std::fs::write`, and `tokio::time::sleep` are intentionally used outside the normal `seal_utils::io` routing, and adds a crate-level `dead_code` allow on `tui_memory_plateau` for the macOS-without-dhat-heap configuration where none of the test bodies are compiled. ## Related issues Refs SEA-634, SEA-714 ## Changes - Added `#[cfg_attr(not(target_os = "linux"), allow(dead_code, reason = "…"))]` to all Linux-only sandbox bridge symbols in `sandbox_spawn/mod.rs` so macOS builds stay warning-free without removing the code. - Added targeted `#[allow(clippy::disallowed_methods, reason = "…")]` blocks in `sandbox_exec_integration.rs` and `dev_server_ports.rs` test fixtures for `std::env::var_os`, `std::fs::write`, `std::thread::sleep`, and `tokio::time::sleep` usages that are intentional and appropriately scoped to test infrastructure. - Switched profile-reading in `macos.rs` tests from `std::fs::read_to_string` to `seal_utils::io::read` + `String::from_utf8` for consistency with the project's I/O conventions. - Added `#![cfg_attr(not(any(target_os = "linux", feature = "dhat-heap")), allow(dead_code))]` to `tui_memory_plateau.rs` to keep the macOS clippy gate green when neither RSS nor heap-profile tests are compiled in. - Fixed a trivial unnecessary-borrow lint by passing `script` directly instead of `&script` in `home_dir_is_not_visible_in_system_mode`. ## Test plan - `just ci` passes on both Linux and macOS with no new warnings. - All existing sandbox integration tests and TUI memory plateau tests continue to pass unchanged.
<!--
Thanks for opening a PR! A few things before submitting:
1. Read CONTRIBUTING.md if this is your first PR (CLA + dev setup).
2. Use Conventional Commits for the PR title:
`feat(scope): subject` / `fix(scope): subject` / `chore(scope): subject`.
3. Run `just ci` locally — it mirrors what CI runs.
Delete sections that don't apply.
-->
# Pull request
## Summary
<!-- One or two sentences: what does this PR do and why? -->
## Related issues
<!-- Closes #NNN — auto-closes the GitHub issue on merge. -->
<!-- Or: "Refs #NNN" if the PR partially addresses an issue. -->
## Changes
<!-- Bullet list of the meaningful changes. Skip if Summary already covers it. -->
-
-
## Test plan
<!--
How did you verify this works? At minimum:
- Which new tests cover the change?
- Which existing tests did you run? (`just ci` is the baseline)
- If UI-touching: a screenshot or screen recording of the new behavior.
- If sandbox-touching: confirm `just ci-live-deps` passes too (it auto-runs
when LLM-layer paths are touched).
-->
-
## Screenshots
<!-- For TUI / CLI output changes. Skip otherwise. -->
## Notes for reviewers
<!-- Anything reviewers should pay particular attention to —
unusual approach, intentional scope cuts, follow-ups planned. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.
The following PRs are included in this draft PR: