Remove stale LGTM suppression pragma#40
Merged
Merged
Conversation
The // lgtm[js/http-to-file-access] pragma was a no-op: LGTM.com was retired in 2022 and modern CodeQL does not read those comments. The explanatory comment above it documents the same reasoning, so the pragma is removed without behavior change. The CodeQL alert itself will be dismissed as a false positive (OUTPUT_PATH is derived from import.meta.url and cannot be influenced by the network response).
There was a problem hiding this comment.
Pull request overview
This PR removes a stale LGTM inline suppression pragma from scripts/fetch-definitions.js. Since LGTM.com was retired and modern CodeQL does not honor LGTM pragmas, keeping the comment could mislead maintainers into thinking the issue is suppressed when it isn’t.
Changes:
- Removed the
// lgtm[js/http-to-file-access]pragma comment. - Kept the surrounding explanatory comment clarifying why
OUTPUT_PATHis not influenced by the HTTP response.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a
// lgtm[js/http-to-file-access]comment in scripts/fetch-definitions.js that has been a no-op since LGTM.com was retired in 2022. Modern CodeQL does not honor inline LGTM pragmas, so it was creating a false sense of suppression.The explanatory comment above it is preserved.
The associated CodeQL alert will be dismissed as a false positive separately:
OUTPUT_PATHis derived fromimport.meta.urlat module load and cannot be influenced by the HTTP response, so there is no path-traversal/arbitrary-write risk.