feat(test): add receipt parity + EIP-1559 checks#3433
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 68b5f50. Configure here.
| return tCtx.Mode == ModeGigaSequential || | ||
| tCtx.Mode == ModeGigaOCC || | ||
| tCtx.Mode == ModeGigaWithRegularStore | ||
| } |
There was a problem hiding this comment.
isGigaMode includes mode unsupported by constructor
Low Severity
isGigaMode() includes ModeGigaWithRegularStore, but NewGigaTestContext — the sole constructor for GigaTestContext — does not treat that mode as giga-enabled (line 77: gigaEnabled only checks ModeGigaSequential and ModeGigaOCC). A context created with ModeGigaWithRegularStore would get a non-giga app via NewTestWrapperWithSc, yet GetTransientReceipt would route to GigaEvmKeeper on that uninitialized app. The sibling constructor NewStateTestContext handles this mode correctly via NewGigaTestWrapperWithRegularStore.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 68b5f50. Configure here.
wen-coding
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this.


Describe your changes and provide context
Improves the giga test suite to check recepits, and adds a check for EIP-1559 txs.
Testing performed to validate your change
Adds test cases, all pass.
Note
Low Risk
Test-only changes that tighten parity assertions; risk is mainly increased flakiness if receipt fields legitimately diverge across executors.
Overview
Adds cross-mode receipt parity checks to
giga_test.goby routingGetTransientReceiptthrough the correct keeper (V2 vs Giga) and asserting equality across consensus-relevant receipt fields (status, gas used, logs bloom/topics, contract address, andEffectiveGasPrice).Updates existing Geth↔Giga and sequential↔OCC comparisons to call
CompareReceipts, adjusts transfer fixtures sotipCap << feeCapto expose EIP-1559 effective price differences, and introducesTestGigaVsGeth_EffectiveGasPrice_DynamicFeeas a regression test formin(feeCap, tip+baseFee)behavior. Also updates the balance-transfer test to compute gas cost fromreceipt.EffectiveGasPriceinstead of a hard-coded gas price.Reviewed by Cursor Bugbot for commit 68b5f50. Bugbot is set up for automated code reviews on this repo. Configure here.