Skip to content

feat(giga): don't fail if evmone can't load#3443

Open
arajasek wants to merge 1 commit into
mainfrom
asr/evmone
Open

feat(giga): don't fail if evmone can't load#3443
arajasek wants to merge 1 commit into
mainfrom
asr/evmone

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

This allows nodes on Ubuntu 22.04 or earlier to use Giga without having to install new deps.

Testing performed to validate your change

Tests pass.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Medium Risk
Changes startup/test initialization to silently skip setting EvmoneVM on load failure, which could alter execution path/performance when evmone is unavailable and risks latent nil-handling issues if downstream code assumes it is set.

Overview
When Giga executor is enabled, app.New no longer panics if gigalib.InitEvmoneVM() fails; it now attempts to load evmone best-effort and only sets GigaEvmKeeper.EvmoneVM on success.

The same best-effort behavior is applied to NewGigaTestWrapperWithRegularStore, so tests/debug wrappers also won’t fail hard if evmone can’t be loaded.

Reviewed by Cursor Bugbot for commit d863917. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 15, 2026, 3:20 PM

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d863917. Configure here.

Comment thread app/app.go
panic(fmt.Sprintf("failed to load evmone: %s", err))
// evmone is loaded best-effort
if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil {
app.GigaEvmKeeper.EvmoneVM = evmoneVM
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silently swallowed error hides evmone load failure

Medium Severity

When gigalib.InitEvmoneVM() returns an error, it is silently discarded with no log message. Node operators have no way to know whether evmone loaded successfully or failed — the err from the if init statement is never logged. Given this is explicitly a "best-effort" load for platform compatibility, a logger.Warn on the error path would be important for diagnosability.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d863917. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.28%. Comparing base (2fb47af) to head (d863917).

Files with missing lines Patch % Lines
app/app.go 0.00% 2 Missing ⚠️
app/test_helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3443   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files        2120     2120           
  Lines      175481   175477    -4     
=======================================
- Hits       104029   104027    -2     
+ Misses      62384    62383    -1     
+ Partials     9068     9067    -1     
Flag Coverage Δ
sei-chain-pr 50.57% <0.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 69.81% <0.00%> (-0.04%) ⬇️
app/test_helpers.go 72.07% <0.00%> (+0.21%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread app/app.go
if err != nil {
panic(fmt.Sprintf("failed to load evmone: %s", err))
// evmone is loaded best-effort
if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only invoked once on startup? Can we add a log here showing the error and say we are switching to geth executor?

BTW, is there any chance that we can't load either the evmone or the geth executor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants