fix: prevent horizontal scroll jump when opening a promotion parameter dropdown#1102
Open
mvanhorn wants to merge 1 commit into
Open
fix: prevent horizontal scroll jump when opening a promotion parameter dropdown#1102mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
mvanhorn
requested review from
DamjanBecirovic,
dexyk,
loadez and
skipi
as code owners
July 9, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Opening a promotion parameter dropdown in the workflow view scrolls the page horizontally back to the pipeline's left edge, because the dropdown's
focus()call triggers the browser's default scroll-into-view on the whole diagram. This change restores focus without the jump:target_params.jsnow focuses the select and text inputs withpreventScroll: trueand preserves the caret position viasetSelectionRangeinstead of relying on the default focus scroll.Added mocha specs in
switch.spec.jsthat stubHTMLElement.prototype.focusand assert both the select and text parameter inputs are focused withpreventScroll: true, and that the caret restore happens throughsetSelectionRange.Fixes #1003
✅ Checklist