ci: request tech-writers and appex review on OpenAPI sync PRs - #2803
Merged
Conversation
The scheduled spec sync had no reviewer config at all, so its PRs opened with an empty review request list. Requesting team reviewers needs org-level member read, which the default GITHUB_TOKEN lacks, so this also switches the PR step to the semgrep-docs-release App already used by update-help-command.yml and drops the DOCS_BOT_TOKEN fallback, which was never created as a secret.
gaprl
marked this pull request as draft
August 21, 2026 19:12
gaprl
marked this pull request as ready for review
August 21, 2026 20:00
gaprl
enabled auto-merge (squash)
August 21, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled OpenAPI spec sync was opening PRs with nobody requested for review — there was no
reviewersorteam-reviewersconfig in the workflow at all. This requeststech-writersandappex. (There is nodocsteam in the org;tech-writersis the equivalent.)Requesting team reviewers needs a token with organization
members: read, which the defaultGITHUB_TOKENcannot have — the workflowpermissions:block has no org-level key at all. So this also switches the PR step to thesemgrep-docs-releaseApp and drops theDOCS_BOT_TOKENfallback, which was never created as a secret, so that expression was silently resolving toGITHUB_TOKEN. IT has since granted the Appmembers: read(confirmed viagh api apps/semgrep-docs-release). Bonus: App-authored PRs trigger Docs CI, so the close/reopen workaround noted in the old comment goes away.Note for whoever merges:
tech-writershas only read+triage on this repo, so it can approve these PRs but not merge them.