Skip to content

Show selected candidate counts in collapsed category headers#2650

Draft
Copilot wants to merge 6 commits intomainfrom
copilot/add-candidate-selection-indicator
Draft

Show selected candidate counts in collapsed category headers#2650
Copilot wants to merge 6 commits intomainfrom
copilot/add-candidate-selection-indicator

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

Collapsed candidate categories could hide voter selections, making it unclear which category contained selected candidates. This adds a compact selection count to collapsed category headers on the ballot screen, while keeping review screens unchanged.

  • Voting Portal

    • Counts selected candidates per category from questionState.
    • Passes a localized summary label only outside review mode.
  • UI Essentials

    • Renders the selected-count label in collapsed CandidatesList headers.
    • Adjusts header layout to wrap cleanly on mobile.
  • Localization

    • Adds selection-count strings across voting portal translations.
const selectedCandidatesLabel =
    !isReview && selectedCandidatesCount > 0
        ? t(
              selectedCandidatesCount === 1
                  ? "candidatesList.selectedCandidate"
                  : "candidatesList.selectedCandidates",
              {count: selectedCandidatesCount}
          )
        : undefined

> [!WARNING]
>
>

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA).

To sign the CLA, please comment on this PR with:
I have read the CLA Document and I hereby sign the CLA

This is a one-time requirement. Once you have signed, all future contributions will be covered.

You can read the full CLA document here: https://github.com/sequentech/step/blob/main/.github/cla/CLA.md


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI and others added 3 commits May 8, 2026 16:46
Copilot AI changed the title [WIP] Add indicator for selected candidates in collapsed lists Show selected candidate counts in collapsed category headers May 8, 2026
Copilot finished work on behalf of edulix May 8, 2026 16:57
Copilot AI requested a review from edulix May 8, 2026 16:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://docs.sequentech.io/docusaurus/pr-preview/pr-2650/

Built to branch doc-previews at 2026-05-08 17:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Copy Markdown
Contributor

@edulix edulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue in this branch to apply the required changes. Also add a comment to the PR with a screenshot of how it looks now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove any changes in this file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the changes from this file in commit 835a539. Current UI screenshot: collapsed category selected count

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awful. Can you please:

  • make a screenshot in different widths (how it would look in mobile and how it would look in a laptop)
  • ensure it shows nicely in mobile as well as in the computer, because right now each of the element of the header seems to resize differently, the candidate name has different behavior than the new indicator.

Agent-Logs-Url: https://github.com/sequentech/step/sessions/7172fe0a-25ef-4193-ab71-22ef9a05fee5

Co-authored-by: edulix <81968+edulix@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

continue in this branch to apply the required changes. Also add a comment to the PR with a screenshot of how it looks now.

Continued on this branch and removed the release-note change in commit 835a539. Current UI screenshot: collapsed category selected count

Copilot finished work on behalf of edulix May 8, 2026 17:33
Copilot AI requested a review from edulix May 8, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants