Skip to content

Make IpcReceiver a futures::Stream - #167

Merged
bors-servo merged 1 commit into
servo:masterfrom
spinda:async
Aug 22, 2017
Merged

Make IpcReceiver a futures::Stream#167
bors-servo merged 1 commit into
servo:masterfrom
spinda:async

Conversation

@spinda

@spinda spinda commented Aug 21, 2017

Copy link
Copy Markdown
Contributor

Extracts the IpcReceiver half of #165.

This is placed behind an async feature so the dependency on futures isn't forced.

Extracts the IpcReceiver half of servo#165.

This is placed behind an `async` feature so the dependency on futures isn't
forced.
@highfive

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

@spinda

spinda commented Aug 21, 2017

Copy link
Copy Markdown
Contributor Author

r? @jdm

@highfive highfive assigned jdm and unassigned pcwalton Aug 21, 2017
@jdm

jdm commented Aug 21, 2017

Copy link
Copy Markdown
Member

@bors-servo: r+

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 484f2c4 has been approved by jdm

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 484f2c4 with merge 583f90c...

bors-servo pushed a commit that referenced this pull request Aug 21, 2017
Make IpcReceiver a futures::Stream

Extracts the IpcReceiver half of #165.

This is placed behind an `async` feature so the dependency on futures isn't forced.
@bors-servo

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 583f90c to master...

@bors-servo
bors-servo merged commit 484f2c4 into servo:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants